-
-
Notifications
You must be signed in to change notification settings - Fork 215
Add tests for Single-schema items and unevaluatedItems #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This should have caused a check to fail =/ |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the test is fine, though the descriptions could be clearer. What do you mean by "items annotation boolean of true/false"? I assume this means items
generates an annotation that indicates whether it successfully evaluated those items?
Wait on merging this till json-schema-org/json-schema-spec#810 is resolved |
@Relequestual I'm assuming given that issue is closed that you have no remaining concerns with this one. Speak up if so otherwise will have a look at whatever the resolution was and make sure it matches here before merging. |
Went to approve this. Found that I can't because it's my own PR! =D |
Looks like the conflicts will need to be manually resolved. OK to leave this to you? =] |
Yeah I can fix them (and forward port). |
Makes it fit a bit better with its neighbors by using similar language in the descriptions. This *precise* case seems uncovered by said neighbors because none precisely have all of: * nested unevaluatedItems * no prefixItems * cases where unevaluatedItems actually gets used for a scenario It's possible that in aggregate all the cases that are here already would catch any bugs this scenario would catch (i.e. it's possible this is redundant in aggregate) but it's safe enough to add just in case obviously.
(Done -- rebased, forward ported, and slightly reworded given we have other tests in this file thankfully at this point.). Green button it is. |
Resolves #291