Skip to content

Add tests for Single-schema items and unevaluatedItems #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

Relequestual
Copy link
Member

Resolves #291

@Relequestual Relequestual added this to the 2019-09 milestone Dec 12, 2019
@Relequestual
Copy link
Member Author

Relequestual commented Dec 12, 2019

@Relequestual

This comment has been minimized.

Copy link
Member

@gregsdennis gregsdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test is fine, though the descriptions could be clearer. What do you mean by "items annotation boolean of true/false"? I assume this means items generates an annotation that indicates whether it successfully evaluated those items?

@Relequestual
Copy link
Member Author

Wait on merging this till json-schema-org/json-schema-spec#810 is resolved

@Julian
Copy link
Member

Julian commented Jun 27, 2022

@Relequestual I'm assuming given that issue is closed that you have no remaining concerns with this one. Speak up if so otherwise will have a look at whatever the resolution was and make sure it matches here before merging.

@Relequestual
Copy link
Member Author

Went to approve this. Found that I can't because it's my own PR! =D

@Relequestual
Copy link
Member Author

Looks like the conflicts will need to be manually resolved. OK to leave this to you? =]

@Julian
Copy link
Member

Julian commented Jun 27, 2022

Yeah I can fix them (and forward port).

Makes it fit a bit better with its neighbors by using similar language
in the descriptions.

This *precise* case seems uncovered by said neighbors
because none precisely have all of:

    * nested unevaluatedItems
    * no prefixItems
    * cases where unevaluatedItems actually gets used for a scenario

It's possible that in aggregate all the cases that are here already
would catch any bugs this scenario would catch (i.e. it's possible this
is redundant in aggregate) but it's safe enough to add just in case
obviously.
@Julian
Copy link
Member

Julian commented Jun 30, 2022

(Done -- rebased, forward ported, and slightly reworded given we have other tests in this file thankfully at this point.). Green button it is.

@Julian Julian merged commit 39d1d24 into json-schema-org:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"unevaluatedItems" and single-schema "items"
3 participants