replace angular.uppercase
with String.prototype.toUpperCase()
(master/v0.8.13)
#977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note that I also created a PR for the develop branch (v1.0), so please do not consider this to be a duplicate (although the fix is the same).
This PR replaces the use of
angular.uppercase
withString.prototype.toUpperCase()
, as AngularJS has removed their helper functions.This PR is intentionally targeted for the master branch, despite the instructions in the contribution guidelines. This fix is necessary for production systems currently using the latest stable version of AngularJS. Since v0.8.13 is still listed as the primary version on NPM, and since v1.0 has been in development for quite some time, it seems reasonable that this fix should be released for v0.8.13 (or v0.8.14, as the case may be) right away.
Fixes Related issues
Checklist
@json-schema-form/angular-schema-form-lead