Skip to content

replace angular.uppercase with String.prototype.toUpperCase() #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2018
Merged

Conversation

rthaut
Copy link
Contributor

@rthaut rthaut commented Jun 24, 2018

Description

This PR replaces the use of angular.uppercase with String.prototype.toUpperCase(), as AngularJS has removed their helper functions.

Fixes Related issues

Checklist

  • I have read and understand the CONTRIBUTIONS.md file
  • I have searched for and linked related issues
  • I have created test cases to ensure quick resolution of the PR is easier
  • I am NOT targeting main branch
  • I did NOT include the dist folder in my PR

@json-schema-form/angular-schema-form-lead

@Anthropic Anthropic merged commit e9a2a8c into json-schema-form:development Jun 24, 2018
@Anthropic
Copy link
Member

Thanks Ryan, feel free to remove any other angular shortcuts you find, I personally never use vendor shortcuts, I wish I had the time to strip them all. Thanks again :)

@JamesKellyBluedrop
Copy link

Question.. how do I get this update into my local code. Thanks!

@Anthropic
Copy link
Member

@JamesKellyBluedrop for now you'd have to copy the code change, I will try to make time to do a bump release within the next week to npm.

@JamesKellyBluedrop
Copy link

Thanks for getting back to me :) I did copy the change in for now and things are working again

PavelFranta-zonky pushed a commit to zonkyio/angular-schema-form that referenced this pull request Feb 20, 2023
replace `angular.uppercase` with `String.prototype.toUpperCase()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants