Skip to content

Refactor test cases that use CLIEngine. #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 51 additions & 73 deletions tests/lib/rules/no-html-messages.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
/**
* @author kazuya kawaguchi (a.k.a. kazupon)
*/
import { CLIEngine, RuleTester } from 'eslint'
import { resolve, join } from 'path'
import { RuleTester } from 'eslint'
import { join } from 'path'
import fs from 'fs'
import assert from 'assert'
import rule = require('../../../lib/rules/no-html-messages')
import plugin = require('../../../lib/index')
import { baseConfigPath } from '../test-utils'
import { testOnFixtures } from '../test-utils'

new RuleTester({
parser: require.resolve('vue-eslint-parser'),
Expand Down Expand Up @@ -101,84 +99,64 @@ new RuleTester({
})

describe('no-html-messages with fixtures', () => {
const cwd = join(__dirname, '../../fixtures/no-html-messages')
let originalCwd: string

before(() => {
originalCwd = process.cwd()
process.chdir(cwd)
})

after(() => {
process.chdir(originalCwd)
})
const cwdRoot = join(__dirname, '../../fixtures/no-html-messages')

describe('valid', () => {
it('should be not detected html messages', () => {
const linter = new CLIEngine({
cwd,
baseConfig: {
extends: [baseConfigPath],
settings: {
'vue-i18n': {
localeDir: `./valid/*.{json,yaml,yml}`
}
}
},
useEslintrc: false,
parserOptions: {
ecmaVersion: 2015
},
rules: {
'@intlify/vue-i18n/no-html-messages': 'error'
testOnFixtures(
{
cwd: join(cwdRoot, './valid'),
localeDir: `*.{json,yaml,yml}`,
ruleName: '@intlify/vue-i18n/no-html-messages'
},
extensions: ['.js', '.vue', '.json', '.yaml', '.yml']
})

linter.addPlugin('@intlify/vue-i18n', plugin)
const messages = linter.executeOnFiles(['.'])
assert.equal(messages.errorCount, 0)
{}
)
})
})

describe('invalid', () => {
it('should be detected html messages', () => {
const linter = new CLIEngine({
cwd,
baseConfig: {
extends: [baseConfigPath],
settings: {
'vue-i18n': {
localeDir: `./invalid/*.{json,yaml,yml}`
}
}
},
useEslintrc: false,
parserOptions: {
ecmaVersion: 2015
},
rules: {
'@intlify/vue-i18n/no-html-messages': 'error'
testOnFixtures(
{
cwd: join(cwdRoot, './invalid'),
localeDir: `*.{json,yaml,yml}`,
ruleName: '@intlify/vue-i18n/no-html-messages'
},
extensions: ['.js', '.vue', '.json', '.yaml', '.yml']
})
linter.addPlugin('@intlify/vue-i18n', plugin)

const messages = linter.executeOnFiles(['.'])
assert.equal(messages.errorCount, 6)

function checkRuleId(path: string) {
const fullPath = resolve(__dirname, path)
const result = messages.results.find(
result => result.filePath === fullPath
)!
assert.equal(result.messages.length, 3)
result.messages.forEach(message => {
assert.equal(message.ruleId, '@intlify/vue-i18n/no-html-messages')
})
}
checkRuleId('../../fixtures/no-html-messages/invalid/en.json')
checkRuleId('../../fixtures/no-html-messages/invalid/en.yaml')
{
'en.json': {
errors: [
{
line: 3,
message: 'used HTML localization message'
},
{
line: 5,
message: 'used HTML localization message'
},
{
line: 6,
message: 'used HTML localization message'
}
]
},
'en.yaml': {
errors: [
{
line: 2,
message: 'used HTML localization message'
},
{
line: 4,
message: 'used HTML localization message'
},
{
line: 5,
message: 'used HTML localization message'
}
]
}
}
)
})
})
})
Loading