Skip to content

Refactor test cases that use CLIEngine. #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2020
Merged

Refactor test cases that use CLIEngine. #113

merged 1 commit into from
Aug 13, 2020

Conversation

ota-meshi
Copy link
Member

This PR refactors test cases that uses CLIEngine to changes it to use testOnFixtures.

@ota-meshi ota-meshi added Type: Refactoring A code change that neither fixes a bug nor adds a feature Type: Testing Adding missing tests or correcting existing tests labels Aug 12, 2020
kazupon
kazupon approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ota-meshi ota-meshi merged commit bb66b7b into master Aug 13, 2020
@ota-meshi ota-meshi deleted the refactor-test branch August 13, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
Type: Refactoring A code change that neither fixes a bug nor adds a feature Type: Testing Adding missing tests or correcting existing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ota-meshi @kazupon