Skip to content

fix: specify package requirements in setup.py #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Apr 22, 2021

Closes #229

Proposed Changes

Move requirements definition into setup.py - it is best practice for library according to https://packaging.python.org/discussions/install-requires-vs-requirements/.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar requested a review from rhajek April 22, 2021 09:58
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #232 (00e3980) into master (e5d3543) will increase coverage by 0.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   90.99%   91.76%   +0.77%     
==========================================
  Files          26       25       -1     
  Lines        2020     2003      -17     
==========================================
  Hits         1838     1838              
+ Misses        182      165      -17     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d3543...00e3980. Read the comment docs.

@bednar bednar changed the title chore: specify package requirements in setup.py fix: specify package requirements in setup.py Apr 22, 2021
@bednar bednar marked this pull request as ready for review April 22, 2021 10:11
@bednar bednar merged commit 5f3ce1f into master Apr 23, 2021
@bednar bednar deleted the chore/specify-requirements-in-setup.py branch April 23, 2021 06:02
@bednar bednar added this to the 1.17.0 milestone Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requirements.txt should not be deployed
2 participants