Skip to content

requirements.txt should not be deployed #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wat-usmdon opened this issue Apr 20, 2021 · 3 comments · Fixed by #232
Closed

requirements.txt should not be deployed #229

wat-usmdon opened this issue Apr 20, 2021 · 3 comments · Fixed by #232
Milestone

Comments

@wat-usmdon
Copy link

Steps to reproduce:
List the minimal actions needed to reproduce the behavior.

  1. Install influxdb_client. pip install influxdb_client.
# dnf install -y python3-pip
# pip3 install influxdb_client

Expected behavior:
Only the influxdb_client library files should be deployed.

Actual behavior:
The influxdb_client requirements.txt file gets deployed to ~/.local/requirements.txt or /usr/local/requirements.txt.

# cat /usr/local/requirements.txt
rx >= 3.0.1
certifi >= 14.05.14
six >= 1.10
python_dateutil >= 2.5.3
setuptools >= 21.0.0
urllib3 >= 1.15.1
pytz>=2019.1

Additionally, the files ciso-requirements.txt extra-requirements.txt and test-requirements.txt are put at the same location.

Specifications:

  • Client Version: 1.11.0, 1.16.0
  • InfluxDB Version: N/A
  • Platform: Ubuntu Focal, Centos 8

Other:

I found this because of another bug openshift/openshift-restclient-python#403. The combination of these two bugs means you cannot successfully run pip3 install influxdb_client openshift because one tries to create the path as a directory and the other tries to create the path as a file.

# pip3 install influxdb_client openshift
...
    error: could not create '/usr/local/requirements.txt': File exists

    ----------------------------------------
Command "/usr/bin/python3.6 -u -c "import setuptools, tokenize;__file__='/tmp/pip-build-har3wcw1/openshift/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-ttrrwxh5-record/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-build-har3wcw1/openshift/
# pip3 install openshift influxdb_client
...
IsADirectoryError: [Errno 21] Is a directory: '/usr/local/requirements.txt'
@bednar
Copy link
Contributor

bednar commented Apr 21, 2021

@wat-usmdon, thanks for using our client, We will take a look.

@bednar
Copy link
Contributor

bednar commented Apr 22, 2021

Hi @wat-usmdon,

Could you check that your issue is fixed by #232? You could install the fixed version by

pip install git+https://github.com/influxdata/influxdb-client-python.git@chore/specify-requirements-in-setup.py

Regards

@wat-usmdon
Copy link
Author

That works for me. Thank you.

@bednar bednar added this to the 1.17.0 milestone Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants