x-forwarded-proto has wrong value

[ryanstevens]

The ternary was evaluating truthy for "," + req.connection.pair which is always true because its always a non empty string. Wrapped actual condition to properly concatenate the product of the ternary. let me know if you prefer the style (req.connection.pair ? 'https' : 'http')

#250

[jfhbrook]

lgtm, cherry-picked. :D Thanks!

[indexzero]

@ryanstevens nice catch.

[rampr]

Seems like I still have the issue.

Only changing it to,
var protoToAppend = "," + (req.connection.pair ? 'https' : 'http');

fixes it.

Looks like + has a higher precedence compared to the ternary operator
https://developer.mozilla.org/en/JavaScript/Reference/Operators/Operator_Precedence

[jfhbrook]

@rampr Interesting. If you'd like to make another pull request I will gladly accept. :)

[rampr]

Sure. Here you go - #266

[jfhbrook]

Thanks!