x-forwarded-proto is set as httpshttps

[ryanstevens]

When receiving proxied traffic from http-proxy the x-forwarded-proto is set as httpshttps.

This line https://github.com/nodejitsu/node-http-proxy/blob/master/lib/node-http-proxy/http-proxy.js#L151

which is currently
var protoToAppend = "," + req.connection.pair ? 'https' : 'http';

needs to be changed to
var protoToAppend = "," + (req.connection.pair ? 'https' : 'http');

With this change, x-forwarded-proto should be set to https,http

[jfhbrook]

@ryanstevens Wanna PR us this change? I'll pull it. :D

[ryanstevens]

#251

[grabbou]

Actually because of that, the code under FAQ "How to force SSL" is not working and causes infinity loop as req.get('X-Forwarded-Proto') !== 'https' always returns false (because it's http,https).

[jcrugzz]

@grabbou make sure you are using the 1.x.x version of http-proxy

[grabbou]

@jcrugzz thanks for the response, how can I check/change that on nodejitsu? Command line / packages.json settings?

For now I only have node engine specified. Actually, I think that forcing SSL's should be done by default if one specified SSL certificates in Nodejitsu dashboard (as it's the only reasonable approach to be honest)

[jcrugzz]

@grabbou if this is about the nodejitsu product please open a support ticket, this is the wrong context for this conversation.

[grabbou]

ok, thanks