Skip to content

Scripting disabled case #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2016
Merged

Scripting disabled case #243

merged 2 commits into from
May 11, 2016

Conversation

gsnedders
Copy link
Member

@gsnedders gsnedders commented May 7, 2016 •
edited
Loading

This essentially rebases #230 as well as squashing it, and fixes tree walker tests to set the scripting flag correctly. Still fixes #10. //cc @neumond

@codecov-io
Copy link

codecov-io commented May 7, 2016 •
edited
Loading

Current coverage is 89.22%

Merging #243 into master will decrease coverage by -<.01%

@@             master       #243   diff @@
==========================================
  Files            50         50          
  Lines          6731       6774    +43   
  Methods           0          0          
  Messages          0          0          
  Branches       1313       1317     +4   
==========================================
+ Hits           6006       6044    +38   
- Misses          555        560     +5   
  Partials        170        170

Powered by Codecov. Last updated by 911cf45...a3207b0

@gsnedders
Copy link
Member Author

So we don't have tests for "in head noscript" insertion mode, that kinda sucks.

@gsnedders
Copy link
Member Author

Also:

(py2-env)pnin:html5lib-python gsnedders$ python parse.py foo.html 
Traceback (most recent call last):
  File "parse.py", line 97, in run
    document = parseMethod(f, encoding=encoding)
  File "/Users/gsnedders/Documents/my-projects/html5lib/html5lib-python/html5lib/html5parser.py", line 239, in parse
    parseMeta=parseMeta, useChardet=useChardet, scripting=scripting)
  File "/Users/gsnedders/Documents/my-projects/html5lib/html5lib-python/html5lib/html5parser.py", line 94, in _parse
    self.mainLoop()
  File "/Users/gsnedders/Documents/my-projects/html5lib/html5lib-python/html5lib/html5parser.py", line 217, in mainLoop
    reprocess = self.phase.processEOF()
  File "/Users/gsnedders/Documents/my-projects/html5lib/html5lib-python/html5lib/html5parser.py", line 469, in processEOF
    raise NotImplementedError
NotImplementedError
(py2-env)pnin:html5lib-python gsnedders$ cat foo.html 
<head><noscript></head>

@neumond
Copy link
Contributor

neumond commented May 7, 2016

Looks good to me.

@gsnedders gsnedders mentioned this pull request May 7, 2016
Closed
@codecov-io
Copy link

codecov-io commented May 7, 2016 •
edited
Loading

Current coverage is 89.13%

Merging #243 into master will decrease coverage by -0.10%

@@             master       #243   diff @@
==========================================
  Files            50         50          
  Lines          6739       6796    +57   
  Methods           0          0          
  Messages          0          0          
  Branches       1314       1318     +4   
==========================================
+ Hits           6013       6057    +44   
- Misses          556        569    +13   
  Partials        170        170
  1. File ...eeadapters/genshi.py (not in diff) was modified. more
    • Misses -1
    • Partials 0
    • Hits +1

Powered by Codecov. Last updated by 323830c...00ee7e1

@gsnedders gsnedders modified the milestone: 0.99999999 May 8, 2016
@gsnedders
Copy link
Member Author

html5lib/html5lib-tests#76 deals with the testing side of things.

@gsnedders gsnedders merged commit 84e8802 into html5lib:master May 11, 2016
@gsnedders gsnedders deleted the noscript branch May 11, 2016 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.99999999
Development

Successfully merging this pull request may close these issues.

Implement scripting disabled case.
3 participants
@gsnedders @codecov-io @neumond