Implement inhead-noscript context, add script parameter to parse #230
Conversation
Current coverage is
|
|
|
|
Looks like something unrelated started to selectively fail or pass depending on version of python. |
| @@ -22,18 +22,18 @@ | |||
|
|
|||
|
|
|||
| def parse(doc, treebuilder="etree", encoding=None, | |||
| namespaceHTMLElements=True): | |||
| namespaceHTMLElements=True, script=True): | |||
There was a problem hiding this comment.
Bikeshed moment: Can we call this scripting?
There was a problem hiding this comment.
Not a problem. I had doubts naming it.
There was a problem hiding this comment.
Also, I'd rather we default to False, given we don't actually implement scripting.
|
@neumond: one hypothesis about the Travis failures: try recreating the expectation file on Python 2.7 (with optional extras installed). |
|
|
|
@gsnedders You were right, tests with cElementTree were not masked under py3. Thanks for solving pytest-expect py2/py3 issues in advance. |
|
@neumond I'll try and add a warning or error if you're updating the tests with the wrong config, given that's totally undocumented and even I'd forgotten what exactly was needed. |
|
@neumond Oh, I hadn't noticed before, but: can you move the option to |
|
Why did I think that a good idea? No, |
|
Superseded by #243. |
48 failing tests now pass.
#script-onand#script-offparameters are now considered in testing.