Upgrade Hibernate ORM to 7.0.0.CR1 #2221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of EventSource
now that refactoring to core haa made this possible
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+187
to
+188
| factory.getServiceRegistry().requireService( BatchLoaderFactory.class ) | ||
| .createEntityBatchLoader( domainBatchSize, entityDescriptor, factory ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| list.add( pos < 0 ? null : resultList.get(pos) ); | ||
| return getEntityPersister( entityClass.getName() ) | ||
| .reactiveMultiLoad( sids, this, StatelessSessionImpl.MULTI_ID_LOAD_OPTIONS ) | ||
| .whenComplete( (v, e) -> { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| list.add( pos < 0 ? null : resultList.get(pos) ); | ||
| return getEntityPersister( entityClass.getName() ) | ||
| .reactiveMultiLoad( sids, this, StatelessSessionImpl.MULTI_ID_LOAD_OPTIONS ) | ||
| .whenComplete( (v, e) -> { |
Check notice
Code scanning / CodeQL
Useless parameter Note
Plus, update expected Oracle default database mapping in tests: * `Double` and `double` java types changes from `FLOAT` to `BINARY_DOUBLE` * `Float` and `float` java types changes from `FLOAT` to `BINARY_FLOAT` Changes to ReactiveAbstractSelectionQuery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2220
Fix #2214
If CI is happy, I think we can merge this now