Align the session to the latest changes in ORM 7 #2206
Conversation
DavideD
force-pushed
the
2181-Stateless-session
branch
2 times, most recently
from
6524818 to
0908464
Compare
DavideD
force-pushed
the
2181-Stateless-session
branch
2 times, most recently
from
24e6d2e to
45397c4
Compare
|
@gavinking maybe you can have a look? |
A bit too much there to review all of it line by line, but the fragments I reviewed all look perfect to me. |
|
But we had better add some tests for persistence of collections via the |
Thanks, that's what I needed |
DavideD
force-pushed
the
2181-Stateless-session
branch
2 times, most recently
from
c48c7b0 to
b3f1a7f
Compare
It's useful for when we need to map a try-finally block.
I'm going to add this because ORM log this message when a JDBCException happens. I don't expect it to happen in Hibernate Reactive, but I don't have time now to check for sure.
DavideD
force-pushed
the
2181-Stateless-session
branch
from
b3f1a7f to
e54a21f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /** | ||
| * @see SessionImpl#load(LoadEventListener.LoadType, Object, String, LockOptions, Boolean) | ||
| */ | ||
| public CompletionStage<Object> reactiveLoad(LoadEventListener.LoadType loadType, Object id, String entityName, LockOptions lockOptions, Boolean readOnly) { |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
| @@ -224,12 +223,12 @@ | |||
|
|
|||
| return getEntityPersister( entityClass.getName() ) | |||
| .reactiveMultiLoad( sids, this, StatelessSessionImpl.MULTI_ID_LOAD_OPTIONS ) | |||
| .whenComplete( (v, e) -> { | |||
| .whenComplete( (list, e) -> { | |||
Check notice
Code scanning / CodeQL
Useless parameter Note
| @@ -224,12 +223,12 @@ | |||
|
|
|||
| return getEntityPersister( entityClass.getName() ) | |||
| .reactiveMultiLoad( sids, this, StatelessSessionImpl.MULTI_ID_LOAD_OPTIONS ) | |||
| .whenComplete( (v, e) -> { | |||
| .whenComplete( (list, e) -> { | |||
Check notice
Code scanning / CodeQL
Useless parameter Note
|
I'm going to merge it and create an issue to remember to add the missing tests for the StatelessSession |
Perfect. Note that there are new tests in ORM that you can easily copy/paste. |
Fix #2181
Mainly a first draft that I think it's reasonable to release for now.
But, the ReactiveSessionImpl needs more work. I will continue to look into it,
but I don't want to delay the Hibernate ORM release.
Merge after #2221