Skip to content

Fix for creation and dropping options of ids temporary tables #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

DavideD
Copy link
Member

@DavideD DavideD commented Feb 13, 2025

Fix #2055
Supersedes #2103

I refactored the test class and removed a leftover

…ionFactory.close()

PersistentTemporaryTable dropping is obtained setting PersistentTableStrategy.DROP_ID_TABLES to true
The test is for temporary tables created for
storing ids
@DavideD DavideD force-pushed the HREACT-69-refactoring branch from c8e4fb4 to 3f77c6a Compare February 13, 2025 07:58
Copy link
Member

@dreab8 dreab8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the review and the improvement 👍

@DavideD DavideD merged commit ebf17e1 into hibernate:main Feb 13, 2025
19 checks passed
@DavideD
Copy link
Member Author

DavideD commented Feb 13, 2025

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting hibernate.query.mutation_strategy.global_temporary.create_tables to false has no effect
2 participants