-
Notifications
You must be signed in to change notification settings - Fork 96
Setting hibernate.query.mutation_strategy.global_temporary.create_tables to false has no effect #2103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this test fails for CockroachDB, probably because it always uses temporary tables (just a guess, I haven't actually checked).
I also noticed that we make the same mistake when we need to drop temporary tables. Could you fix this as well, please?
There is also a typo.
Thanks!
...nate-reactive-core/src/test/java/org/hibernate/reactive/schema/GlobalTemporaryTableTest.java
Outdated
Show resolved
Hide resolved
...nate-reactive-core/src/test/java/org/hibernate/reactive/schema/GlobalTemporaryTableTest.java
Outdated
Show resolved
Hide resolved
...nate-reactive-core/src/test/java/org/hibernate/reactive/schema/GlobalTemporaryTableTest.java
Outdated
Show resolved
Hide resolved
...ate/reactive/query/sqm/mutation/internal/temptable/ReactiveGlobalTemporaryTableStrategy.java
Show resolved
Hide resolved
ff2de4e
to
d9646ba
Compare
...te-reactive-core/src/test/java/org/hibernate/reactive/schema/AbstractTemporaryTableTest.java
Fixed
Show fixed
Hide fixed
…porary.create_tables to false has no effect
…ionFactory.close() PersistentTemporaryTable dropping is obtained setting PersistentTableStrategy.DROP_ID_TABLES to true
91569b5
to
c0cb474
Compare
…gy.global_temporary.create_tables to false has no effect
Fix #2055