Skip to content

Replace DBSelectionExtension with annotations #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
blafond opened this issue Jan 8, 2024 · 0 comments · Fixed by #1842
Closed

Replace DBSelectionExtension with annotations #1827

blafond opened this issue Jan 8, 2024 · 0 comments · Fixed by #1842
Labels
testing Improvements to test suite
Milestone
2.2.2.Final

Comments

@blafond
Copy link
Member

blafond commented Jan 8, 2024

The current DBSelectionExtension only provides class level management of what DB's to run or skip. Some test methods have been failing in a test, but options only include using RunOnlyFor( dbs...) or SkipTestsFor for all test cases.

Currently there are some tests that use the @disabled annotation, but the tests are disabled for ALL DBTypes.

Create annotations that will allow running tests that can skip or run with individual test methods as well all tests in the test class.
@blafond blafond mentioned this issue Jan 10, 2024
Closed
blafond added a commit to blafond/hibernate-reactive that referenced this issue Jan 18, 2024
@blafond
[hibernate#1827] create EnableFor and DisableFor annotations
a14d0cb
blafond added a commit to blafond/hibernate-reactive that referenced this issue Jan 18, 2024
@blafond
[hibernate#1827] tests to verify new annotations
8ca6cb9
blafond added a commit to blafond/hibernate-reactive that referenced this issue Jan 18, 2024
@blafond
[hibernate#1827] replace DBSelectionExtension with java annotations
2d9e701
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Jan 19, 2024
@blafond @DavideD
[hibernate#1827] create EnableFor and DisableFor annotations
9a40344
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Jan 19, 2024
@blafond @DavideD
[hibernate#1827] tests to verify new annotations
31114af
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Jan 19, 2024
@blafond @DavideD
[hibernate#1827] replace DBSelectionExtension with java annotations
6fcb6b0
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Jan 22, 2024
@blafond @DavideD
[hibernate#1827] Create @EnabledFor and @DisabledFor annotations
6104b21
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Jan 22, 2024
@blafond @DavideD
[hibernate#1827] Test @EnabledFor and @DisabledFor annotations
10d90c1
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Jan 22, 2024
@blafond @DavideD
[hibernate#1827] Replace DBSelectionExtension with java annotations
24f25cf
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jan 22, 2024
@DavideD
[hibernate#1827] Clean up ReactiveConnectionPoolTest
3df2207
@DavideD DavideD mentioned this issue Jan 22, 2024
Merged
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Jan 22, 2024
@blafond @DavideD
[hibernate#1827] Test @EnabledFor and @DisabledFor annotations
0320e75
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Jan 22, 2024
@blafond @DavideD
[hibernate#1827] Replace DBSelectionExtension with java annotations
0573336
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jan 22, 2024
@DavideD
[hibernate#1827] Clean up ReactiveConnectionPoolTest
191558c
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Jan 23, 2024
@blafond @DavideD
[hibernate#1827] Create @EnabledFor and @DisabledFor annotations
39f13d6
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Jan 23, 2024
@blafond @DavideD
[hibernate#1827] Test @EnabledFor and @DisabledFor annotations
2d47479
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Jan 23, 2024
@blafond @DavideD
[hibernate#1827] Replace DBSelectionExtension with java annotations
2de3ac7
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jan 23, 2024
@DavideD
[hibernate#1827] Clean up ReactiveConnectionPoolTest
d54f2bb
DavideD pushed a commit that referenced this issue Jan 23, 2024
@blafond @DavideD
[#1827] Create @EnabledFor and @DisabledFor annotations
afdddd9
DavideD pushed a commit that referenced this issue Jan 23, 2024
@blafond @DavideD
[#1827] Test @EnabledFor and @DisabledFor annotations
6a147af
DavideD pushed a commit that referenced this issue Jan 23, 2024
@blafond @DavideD
[#1827] Replace DBSelectionExtension with java annotations
39b86de
DavideD added a commit that referenced this issue Jan 23, 2024
@DavideD
[#1827] Clean up ReactiveConnectionPoolTest
4d8c5a6
@DavideD DavideD added this to the 2.2.2.Final milestone Jan 24, 2024
@DavideD DavideD added the testing Improvements to test suite label Jan 24, 2024
@DavideD DavideD mentioned this issue Apr 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Improvements to test suite
Projects
None yet
Milestone
2.2.2.Final
2 participants
@DavideD @blafond