Skip to content

check tests currently disabled for certain dialects #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
blafond opened this issue Dec 18, 2023 · 4 comments
Closed

check tests currently disabled for certain dialects #1823

blafond opened this issue Dec 18, 2023 · 4 comments

Comments

@blafond
Copy link
Member

blafond commented Dec 18, 2023

A number of tests are currently disabled due to errors for specific dialects.

Re-run these tests and enable if tests work.
@DavideD
Copy link
Member

DavideD commented Dec 19, 2023

Ok, but make sure that there is an issue for each disabled test so that we don't forget about them

@blafond
Copy link
Member Author

blafond commented Dec 19, 2023

sure thing.

Here's my first pass: blafond@2401872

@DavideD
Copy link
Member

DavideD commented Dec 20, 2023

Mmmh.... OK. But from the description of the issue I didn't expect this kind of refactoring.
Could you update the description and title?

Is this issue about checking which tests we might enable, or is it about removing the custom extension for JUnit? Or both?

@DavideD
Copy link
Member

DavideD commented Apr 19, 2024

I think this has been superseded by #1827

@DavideD DavideD closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DavideD @blafond