Fix: Use os.readlink instead of Path.readlink before Python 3.9. #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Path.readlink` is not available before Python 3.9, which is causing the tool to complain in a project I'm working on. This code was implemented as `os.readlink()` before rules_python was introduced (per hedronvision@0e5b1aa), but didn't seem to be reverted when rules_python was reverted. Verified locally that this fixes the issue for me.
|
Thanks for flagging and for contributing a fix, Jincheng! Sorry about that. Merging! (I also added a conversion to a pathlib path to avoid a spurious error about the prior link pointing to the wrong place. Otherwise os.readlink returns a string which fails comparison with a later path.) Thanks and happy coding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path.readlinkis not available before Python 3.9, which is causing the tool to complain in a project I'm working on. This code was implemented asos.readlink()before rules_python was introduced (per 0e5b1aa), but didn't seem to be reverted when rules_python was reverted.Verified locally that this fixes the issue for me.