Skip to content

test: No warnings #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Sep 28, 2021
Merged

test: No warnings #9

merged 24 commits into from
Sep 28, 2021

Conversation

jimfulton
Copy link

@jimfulton jimfulton commented Sep 26, 2021 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2 🦕

This builds-on/includes #8, which builds-on/includes #7.

@jimfulton jimfulton requested a review from a team as a code owner September 26, 2021 22:46
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. label Sep 26, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2021
@jimfulton
Copy link
Author

Note there are some commits to address comments made on googleapis/python-bigquery#972 :)

@jimfulton jimfulton mentioned this pull request Sep 27, 2021
Merged
4 tasks
@jimfulton jimfulton added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 27, 2021
plamut
plamut approved these changes Sep 27, 2021
View reviewed changes
Copy link

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the comments from googleapis/python-bigquery#972 have been addressed.

Thanks for this!

@tswast tswast added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 27, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 27, 2021
@tswast
Copy link
Collaborator

tswast commented Sep 27, 2021

Coverage failure to be addressed in #11

@jimfulton
Copy link
Author

Coverage failure to be addressed in #11

Oops, I addressed it here.

tswast
tswast approved these changes Sep 28, 2021
View reviewed changes
tests/unit/test_dtypes.py


@for_date_and_time
def test_date___arrow__array__(dtype):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: remove in #11

@google-cla
Copy link

google-cla bot commented Sep 28, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 28, 2021
@tswast
Copy link
Collaborator

tswast commented Sep 28, 2021

@googlebot I consent.

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 28, 2021
@tswast tswast added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Sep 28, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 28, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit c65ff18 into main Sep 28, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the no-warnings branch September 28, 2021 21:56
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@plamut plamut plamut approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

elementwise comparison deprecation warnings in unit tests
4 participants
@jimfulton @tswast @plamut @yoshi-kokoro