Skip to content

elementwise comparison deprecation warnings in unit tests #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tswast opened this issue Sep 23, 2021 · 0 comments · Fixed by #9
Closed

elementwise comparison deprecation warnings in unit tests #2

tswast opened this issue Sep 23, 2021 · 0 comments · Fixed by #9
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. type: process A process-related concern. May include testing, release, or the like.

Comments

@tswast
Copy link
Collaborator

tswast commented Sep 23, 2021 

============================================================= warnings summary =============================================================
tests/unit/test_dtypes.py::test_timearray_comparisons[left0-==-right0-expected0-date]
tests/unit/test_dtypes.py::test_timearray_comparisons[left0-==-right0-expected0-date]
tests/unit/test_dtypes.py::test_timearray_comparisons[left0-==-right0-expected0-time]
tests/unit/test_dtypes.py::test_timearray_comparisons[left0-==-right0-expected0-time]
tests/unit/test_dtypes.py::test_timearray_comparisons[left1-==-right1-expected1-date]
tests/unit/test_dtypes.py::test_timearray_comparisons[left1-==-right1-expected1-date]
tests/unit/test_dtypes.py::test_timearray_comparisons[left1-==-right1-expected1-time]
tests/unit/test_dtypes.py::test_timearray_comparisons[left1-==-right1-expected1-time]
  /Users/swast/src/github.com/googleapis/python-db-dtypes-pandas/tests/unit/test_dtypes.py:142: DeprecationWarning: elementwise comparison failed; this will raise an error in the future.
    "==": (lambda a, b: a == b),

tests/unit/test_dtypes.py::test_timearray_comparisons[left0-==-right0-expected0-date]
tests/unit/test_dtypes.py::test_timearray_comparisons[left0-==-right0-expected0-date]
tests/unit/test_dtypes.py::test_timearray_comparisons[left0-==-right0-expected0-time]
tests/unit/test_dtypes.py::test_timearray_comparisons[left0-==-right0-expected0-time]
tests/unit/test_dtypes.py::test_timearray_comparisons[left1-==-right1-expected1-date]
tests/unit/test_dtypes.py::test_timearray_comparisons[left1-==-right1-expected1-date]
tests/unit/test_dtypes.py::test_timearray_comparisons[left1-==-right1-expected1-time]
tests/unit/test_dtypes.py::test_timearray_comparisons[left1-==-right1-expected1-time]
  /Users/swast/src/github.com/googleapis/python-db-dtypes-pandas/tests/unit/test_dtypes.py:147: DeprecationWarning: elementwise comparison failed; this will raise an error in the future.
    "==": (lambda a, b: a != b),

tests/unit/test_dtypes.py: 16 warnings
  /Users/swast/src/github.com/googleapis/python-db-dtypes-pandas/.nox/unit-3-7/lib/python3.7/site-packages/numpy/core/numeric.py:2446: DeprecationWarning: elementwise comparison failed; this will raise an error in the future.
    return bool(asarray(a1 == a2).all())

tests/unit/test_dtypes.py::test_min_max_median[date]
tests/unit/test_dtypes.py::test_min_max_median[time]
  /Users/swast/src/github.com/googleapis/python-db-dtypes-pandas/.nox/unit-3-7/lib/python3.7/site-packages/numpy/lib/nanfunctions.py:1117: RuntimeWarning: Mean of empty slice
    return np.nanmean(a, axis, out=out, keepdims=keepdims)
@tswast tswast added api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. type: process A process-related concern. May include testing, release, or the like. labels Sep 23, 2021
@jimfulton jimfulton mentioned this issue Sep 26, 2021
Merged
4 tasks
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 28, 2021
test: No warnings (#9)
c65ff18 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-db-dtypes-pandas/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Fixes #2 🦕

This builds-on/includes #8, which builds-on/includes #7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: No warnings googleapis/python-db-dtypes-pandas
1 participant
@tswast