Skip to content

dev: do not print extra whitespace in deprecated lint log #3596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2023
Merged

dev: do not print extra whitespace in deprecated lint log #3596

merged 1 commit into from
Feb 16, 2023

Conversation

alexandear
Copy link
Member

This PR removes extra whitespace in the warning log about deprecated linter.

Instead of

WARN [runner] The linter "golint" is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner.  Replaced by revive.

now prints without two whitespaces after the owner

WARN [runner] The linter "golint" is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner. Replaced by revive.

@alexandear alexandear mentioned this pull request Feb 16, 2023
Closed
@alexandear alexandear added area: docs topic: cosmetic changes contain cosmetic improvements labels Feb 16, 2023
@alexandear alexandear changed the title feat: don't print extra whitespace in deprecated lint log dev: don't print extra whitespace in deprecated lint log Feb 16, 2023
@alexandear alexandear changed the title dev: don't print extra whitespace in deprecated lint log dev: do not print extra whitespace in deprecated lint log Feb 16, 2023
ldez
ldez approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit e8524ac into golangci:master Feb 16, 2023
@alexandear alexandear deleted the replaced-by-without-extra-space branch February 16, 2023 10:05
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@alexandear @SeigeC
dev: do not print extra whitespace in deprecated lint log (golangci#3596
170f25b 
)
@ldez ldez added this to the v1.51 milestone Mar 6, 2024
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area: docs topic: cosmetic changes contain cosmetic improvements
Projects
None yet
Milestone
v1.51
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @ldez