Skip to content

dev: do not print extra whitespace in deprecated lint log #3594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

alexandear
Copy link
Member

This PR removes extra whitespace in the warning log about deprecated linter.

Instead of

WARN [runner] The linter "golint" is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner.  Replaced by revive.

now prints without two whitespaces after the owner

WARN [runner] The linter "golint" is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner. Replaced by revive.

@ldez ldez changed the title feat: do not print extra whitespace in deprecated lint log dev: do not print extra whitespace in deprecated lint log Feb 15, 2023
@ldez ldez added area: docs topic: cosmetic changes contain cosmetic improvements labels Feb 15, 2023
@ldez
Copy link
Member

ldez commented Feb 15, 2023

Hello @alexandear,

Can you use your fork to create a branch instead of the main repo? thank you.

#3584 (comment)

@ldez
Copy link
Member

ldez commented Feb 15, 2023

I will close this PR because this uses a branch on the main repository instead of using a branch from a fork.

@ldez ldez closed this Feb 15, 2023
@ldez ldez added the declined label Feb 15, 2023
@ldez ldez deleted the replaced-by-without-extra-space branch February 15, 2023 19:13
@alexandear
Copy link
Member Author

Hello @ldez. Sorry, didn't see that gh tool pushed to the main repo. Thanks for pointing me out.
Created a fork and re-submitted PR #3596.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs declined topic: cosmetic changes contain cosmetic improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants