-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Use Docker Compose for testing #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
#696 was merged and there is now a conflict in |
3dcbab0
to
4163dc2
Compare
PTAL. Two tests are failing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this.
Please don't forget to update Wiki Page after merge.
I don't have permissions for this. |
Poke @julienschmidt |
Hi @AlekSi, my plan would be to merge this shortly after the 1.4.0 release, which I hope we will have ready tomorrow. The wiki write access is currently restricted since many edits weren't exactly improving the content when everyone could edit it. Of course you could post the changes and someone with write access can apply them — or if you and/or the other Percona folks have a long-term interest in contributing to this project, I would also be open to talk about giving push access to the repository (which unfortunately can not be separated from wiki write access). A few more hands certainly wouldn't hurt. |
Rebased, PTAL. |
In general it looks fine to me. |
prot = env("MYSQL_TEST_PROT", "tcp") | ||
addr = env("MYSQL_TEST_ADDR", "localhost:3306") | ||
addr = env("MYSQL_TEST_ADDR", "127.0.0.1:3307") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't change default port to 3307
I close this because we moved to GitHub Actions. |
Description
See #695 and https://travis-ci.org/AlekSi/mysql.
When this is merged, https://github.com/go-sql-driver/mysql/wiki/Testing needs to be updated.
Checklist