Skip to content

Use Docker Compose for testing #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlekSi opened this issue Oct 27, 2017 · 8 comments
Closed

Use Docker Compose for testing #695

AlekSi opened this issue Oct 27, 2017 · 8 comments
Assignees
Labels

Comments

@AlekSi
Copy link
Contributor

AlekSi commented Oct 27, 2017

It can be used to simplify Travis CI configuration, add less painful testing with different versions of MySQL, as well as enable easier local testing. For example, see Prometheus' mysqld_exporter:

I can work on it if you are interested.

@julienschmidt
Copy link
Member

If you feel like this would beneficial, we would be happy to accept a PR!
We would e.g. also like to test different authentication methods, which seems cumbersome to set up with Travis.

@methane
Copy link
Member

methane commented Oct 30, 2017

I don't like running 4 * 9 = 36 builds for every pull requests...
Could you make it more efficient to reduce resource usage on Travis?

@AlekSi
Copy link
Contributor Author

AlekSi commented Oct 30, 2017

Sure. What combinations should be excluded?

@methane
Copy link
Member

methane commented Oct 30, 2017

  • All Go versions should be tested with latest stable MySQL (5.7 for now)
  • All MySQL and MariaDB versions should be tested with latest stable Go (1.9 for now)

4 + 9 - 1 = 12 builds are tested.

@AlekSi
Copy link
Contributor Author

AlekSi commented Oct 30, 2017

That way you will miss that unique failure with Go 1.7 and MySQL 5.5: https://travis-ci.org/AlekSi/mysql/jobs/294436832

@methane
Copy link
Member

methane commented Oct 30, 2017

Is it really issue reproducible only on MySQL 5.5 and Go 1.7 combination?
Isn't it a random failure?

@AlekSi
Copy link
Contributor Author

AlekSi commented Oct 30, 2017

You are right, now it looks like a random failure to me.
I will do as you proposed.

@methane
Copy link
Member

methane commented Jan 6, 2021

Close because we have moved to GitHub Actions.

@methane methane closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants