make tls=true do the same thing as tls=. otherwise it's pretty useless. #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienschmidt
requested changes
Mar 27, 2017
| @@ -293,11 +293,11 @@ Default: OS default | |||
|
|
|||
| ``` | |||
| Type: bool / string | |||
| Valid Values: true, false, skip-verify, <name> | |||
| Valid Values: true, false, skip-verify, <name>, <empty> | |||
There was a problem hiding this comment.
While I agree that we need a fix for tls=true, <empty> should not be a valid (/recommended) value. It doesn't make sense semantically and is the same as tls=true, I assume?
| Default: false | ||
| ``` | ||
|
|
||
| `tls=true` enables TLS / SSL encrypted connection to the server. Use `skip-verify` if you want to use a self-signed or invalid certificate (server side). Use a custom value registered with [`mysql.RegisterTLSConfig`](https://godoc.org/github.com/go-sql-driver/mysql#RegisterTLSConfig). | ||
| Every value other than `false` enables TLS/SSL encrypted connection to the server. Use `skip-verify` if you want to use a self-signed or invalid certificate (server side). Use a custom `<name>` if you've registered it with [`mysql.RegisterTLSConfig`](https://godoc.org/github.com/go-sql-driver/mysql#RegisterTLSConfig). Both `true` and `<empty>` will use use the `host` from the address for the expected `ServerName`. |
There was a problem hiding this comment.
Please do not add double spaces after full stops.
|
Fixed by #564 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tls=truein the dsn creates an emptytls.Config{}, which when used results in the error:This change makes
tls=truebehave the same astls=, that is it uses the hostname portion of the addr as the ServerName.Fixes #527
Checklist