Skip to content

tls example without client certs? #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aaronkavlie-wf opened this issue Dec 8, 2016 · 3 comments
Closed

tls example without client certs? #528

aaronkavlie-wf opened this issue Dec 8, 2016 · 3 comments

Comments

@aaronkavlie-wf
Copy link

Issue description

TLS was a bit confusing because the example code includes a client cert & key. As per discussion here and the mysql client example here it's more common to connect without client cert/key. But without some explanation, the example code makes it look like this is required.

Configuration

Go version: go1.7.4 darwin/amd64

Server version: Amazon Aurora

@dveeden
Copy link
Contributor

dveeden commented Apr 3, 2017

Maybe create a PR to update the docs?

@methane
Copy link
Member

methane commented Apr 3, 2017

The example demonstrates RegisterTLSConfig() API.
Isn't it easy enough to know how to use "custom root CA" from "custom root CA + client cert" example.

Additionally, #543 or #564 will cover common cases.
I don't think adding more example is required for people who can't know A from A+B example.

@julienschmidt
Copy link
Member

#564 is now merged. For most people it should just work "out of the box" with tls=true again. I think we can expect other people to know when they have to register their own config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants