on reconnect in the middle of transaction make sure to reread interrupted transaction #420
Conversation
…ed transaction from the beginning this is another stab at issues go-mysql-org#414 and go-mysql-org#416
| } | ||
|
|
||
| advanceCurrentGtidSet := func(gtid string) error { | ||
| if b.currGset == nil { |
There was a problem hiding this comment.
initially currGset is nil, while prevGset is set
purpose of b.currGset = b.prevGset.Clone() to once allocate memory for currGset so b.currGset.Update call on line 749 can be made
| case *QueryEvent: | ||
| event.GSet = b.getGtidSet() | ||
| event.GSet = getCurrentGtidSet() |
There was a problem hiding this comment.
getCurrentGtidSet is a replacement for BinlogSyncer.getGtidSet()
a. getCurrentGtidSet returns currGset if set
b. it became local function to emphasize scope of usage
|
I have reviewed this and it is a better version of what I initially submitted in #414. Let's merge this ASAP |
|
PTAL @GregoryIan |
gleonid
changed the title
gleonid
changed the title
| @@ -733,33 +733,61 @@ func (b *BinlogSyncer) parseEvent(s *BinlogStreamer, data []byte) error { | |||
| // Some events like FormatDescriptionEvent return 0, ignore. | |||
| b.nextPos.Pos = e.Header.LogPos | |||
| } | |||
|
|
|||
| getCurrentGtidSet := func() GTIDSet { | |||
There was a problem hiding this comment.
can we move these two functions to outside?
There was a problem hiding this comment.
we can, however having those functions local emphasizes that they are used/called only in scope of parseEvent.
gleonid
force-pushed
the
reconnect_in_middle_of_transaction
branch
from
0be9111 to
697f001
Compare
…pted transaction (go-mysql-org#420) * on reconnect in the middle of transaction make sure to read interrupted transaction from the beginning this is another stab at issues go-mysql-org#414 and go-mysql-org#416
this is another stab at issues #414 and #416
on reconnect in the middle of transaction make sure to read interrupted transaction from the beginning
summary of proposed solution:
prevGset,currGsetonBinlogSyncerprevGsetGTIDEvent/MariadbGTIDEventadvance
prevGset(assigncurrGsetvalue)advance
currGsetto value extracted from binlogXIDEvent/QueryEventalways usecurrGset