Fix re-sync from bad position #414
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from more_patch to master * commit '508a49d838caa77b4144249ae3cee11c6d06ac7b': Fix crash
|
Thanks @ianzapolsky CI failed. |
IANTHEREAL
reviewed
Aug 30, 2019
| if err != nil { | ||
| return errors.Trace(err) | ||
| if b.currGset == nil { | ||
| gset, err := ParseGTIDSet(MySQLFlavor, u.String()) |
There was a problem hiding this comment.
here b.currGset is a single gtid, not a full gtid set, right?
IANTHEREAL
reviewed
Aug 30, 2019
| } | ||
| case *XIDEvent: | ||
| b.prevGset = b.currGset.Clone() |
There was a problem hiding this comment.
as ditto comment, b.currGset would miss some gtids
amyangfei
reviewed
Aug 30, 2019
| event.GSet = b.getGtidSet() | ||
| case *QueryEvent: | ||
| b.prevGset = b.currGset.Clone() |
There was a problem hiding this comment.
b.currGset may be nil, is it better to add a function like getGitdSet
|
ping @ianzapolsky , thanks for your pr, please fix CI |
This was referenced Sep 1, 2019
|
BTW, please also fix the issue does this still have a problem with the Originally posted by @amyangfei in #416 |
gleonid
added a commit
to gleonid/go-mysql
that referenced
this pull request
Sep 2, 2019
…ed transaction from the beginning this is another stab at issues go-mysql-org#414 and go-mysql-org#416
|
thanks @ianzapolsky I will close this PR. |
ghost
pushed a commit
to actiontech/go-mysql
that referenced
this pull request
Nov 26, 2020
…pted transaction (go-mysql-org#420) * on reconnect in the middle of transaction make sure to read interrupted transaction from the beginning this is another stab at issues go-mysql-org#414 and go-mysql-org#416
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where siddontang skips a transaction when re-connecting to the database after its connection is severed.