Skip to content

Revert "[supervisor] improve docker activation (#18143)" #18236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/supervisor/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ require (
github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0
github.com/grpc-ecosystem/grpc-gateway/v2 v2.11.3
github.com/improbable-eng/grpc-web v0.14.0
github.com/mailru/easygo v0.0.0-20190618140210-3c14a0dc985f
github.com/prometheus/client_golang v1.14.0
github.com/prometheus/client_model v0.3.0
github.com/prometheus/common v0.42.0
Expand Down Expand Up @@ -115,7 +116,6 @@ require (
github.com/mitchellh/go-homedir v1.1.0 // indirect
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
github.com/modern-go/reflect2 v1.0.2 // indirect
github.com/moredure/easygo v0.0.0-20220122214504-21cd2ebdd15b
github.com/opencontainers/go-digest v1.0.0 // indirect
github.com/opencontainers/image-spec v1.0.2 // indirect
github.com/opencontainers/runtime-spec v1.0.2 // indirect
Expand Down
4 changes: 2 additions & 2 deletions components/supervisor/go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 2 additions & 9 deletions components/supervisor/pkg/activation/activation.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ import (
"os"
"sync"

"github.com/gitpod-io/gitpod/common-go/log"
"github.com/moredure/easygo/netpoll"
"github.com/mailru/easygo/netpoll"
"golang.org/x/xerrors"
)

Expand All @@ -20,22 +19,16 @@ type Callback func(socketFD *os.File) error

// Listen polls on the listener and calls callback when someone writes to it.
func Listen(ctx context.Context, l net.Listener, activate Callback) error {
poller, err := netpoll.New(&netpoll.Config{
OnWaitError: func(err error) {
log.WithError(err).Error("netpoll: wait loop error")
},
})
poller, err := netpoll.New(nil)
if err != nil {
return err
}
defer poller.Close()

// Get netpoll descriptor with EventRead|EventEdgeTriggered.
desc, err := netpoll.HandleListener(l, netpoll.EventRead|netpoll.EventEdgeTriggered)
if err != nil {
return err
}
defer desc.Close()

var (
runc = make(chan bool, 1)
Expand Down
280 changes: 0 additions & 280 deletions components/supervisor/pkg/supervisor/docker.go

This file was deleted.

Loading