Skip to content

Revert "[supervisor] improve docker activation (#18143)" #18236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2023
Merged

Revert "[supervisor] improve docker activation (#18143)" #18236

merged 1 commit into from
Jul 11, 2023

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Jul 11, 2023 •
edited
Loading

This reverts commit 0f9d319.

Description

This reverts a PR which was recently shipped and we suspect it caused an incident with folder permissions when untaring a workspace backup (for prebuilt / existing workspaces).

We suspect it is caused by

gitpod/components/supervisor/pkg/supervisor/docker.go

Line 160 in 71ff74e

_ = os.Chown(fn, gitpodUID, gitpodGID)

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@filiptronicek filiptronicek requested a review from a team July 11, 2023 12:17
@roboquat roboquat merged commit 9b21205 into main Jul 11, 2023
@roboquat roboquat deleted the ide/revert-supervisor-docker-changes branch July 11, 2023 12:29
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jul 11, 2023
@kylos101 kylos101 mentioned this pull request Jul 11, 2023
Closed
iQQBot added a commit that referenced this pull request Jul 14, 2023
@iQQBot
Revert "Revert "[supervisor] improve docker activation (#18143)" (#18236
7512b9f 
)"

This reverts commit 9b21205.
@iQQBot iQQBot mentioned this pull request Jul 14, 2023
Merged
13 tasks
roboquat pushed a commit that referenced this pull request Jul 17, 2023
@iQQBot
[supervisor] improve docker activation (#18284)
9bb400b 
* Revert "Revert "[supervisor] improve docker activation (#18143)" (#18236)"

This reverts commit 9b21205.

* only start docker activation if content is ready
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iQQBot iQQBot iQQBot approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production size/XL team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filiptronicek @iQQBot @roboquat