[server] snapshots for PVC workspaces #14503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-se-pvc-snapshot.1 because the annotations in the pull request description changed |
|
started the job as gitpod-build-se-pvc-snapshot.2 because the annotations in the pull request description changed |
|
/werft run 👍 started the job as gitpod-build-se-pvc-snapshot.3 |
|
@sagor999 Creating a snapshot takes very long (minutes). When trying to start the resulting snapshot an image build was triggered and the workspace then failed: |
easyCZ
reviewed
Nov 8, 2022
| @@ -306,6 +308,33 @@ export class PromisifiedWorkspaceManagerClient implements Disposable { | |||
| ); | |||
| } | |||
|
|
|||
| public checkVolumeSnapshotIsReady( | |||
There was a problem hiding this comment.
[aside] This client would be a good candidate to use the "cleaner generated grpc client" on
|
/hold for dependency on #14374 |
easyCZ
approved these changes
Nov 8, 2022
sagor999
force-pushed
the
pavel/pvcsnapshot
branch
from
0a9773c to
ed95dae
Compare
sagor999
force-pushed
the
se/pvc-snapshot
branch
from
ac38082 to
daf89d0
Compare
sagor999
force-pushed
the
se/pvc-snapshot
branch
from
daf89d0 to
4ba0ca2
Compare
sagor999
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the server part to #14374
Related Issue(s)
contributes to #14159
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide