Allow to take and then check snapshot status when using pvc

[sagor999]

Description

First part of allowing to take a workspace snapshot that uses PVC.
Second part to make it actually work is for webapp to implement necessary changes.

Related Issue(s)

Related #14159

How to test

Release Notes

none

Documentation

Werft options:

• /werft with-local-preview
  If enabled this will build install/preview
• /werft with-preview
• /werft with-large-vm
• /werft with-integration-tests=all
  Valid options are all, workspace, webapp, ide

[jenting]

@sagor999
Can we use gp snapshot to do the test?
Or do we need the WebApp change to test against this PR?

[sagor999]

@jenting good idea. I think we can test snapshot creation for sure, not sure if restore would work out of the box or would require some tweaking on webapp side.
will test it tomorrow.

[sagor999]

@jenting gp snapshot works by calling takeSnapshot on the server (webapp). Which makes sense, so that it follows same code path. But that also means that until webapp implements their part, we cannot directly call TakeSnapshot on wsman via gp snapshot.

[kylos101]

@sagor999 @jenting 👋 a couple other options to consider for testing:

1. maybe gpctl workspaces snapshot will do?
2. if not, can we test the endpoint using https://github.com/fullstorydev/grpcurl?

[jenting]

Code change LGTM

But I need to find a way to verify it so put a hold label

/hold

[werft-gitpod-dev-com]

started the job as gitpod-build-pavel-pvcsnapshot.10 because the annotations in the pull request description changed
(with .werft/ from main)

[sagor999]

Pinged @svenefftinge in slack with info. VolumeSnapshot is not passed into StartWorkspace call when restoring from snapshot. Asked for his help to look from webapp side why so.

[svenefftinge]

Pinged @svenefftinge in slack with info. VolumeSnapshot is not passed into StartWorkspace call when restoring from snapshot. Asked for his help to look from webapp side why so.

Maybe I'm confused by snapshot names, ids, handles, etc. but I think we need to return the snapshotHandle from ws-amanger's TakeSnapShot and GetVolumeSnapshot. Looks like it is only set on finalize workspace and then passed through the status update atm.

[easyCZ]

Moving this to draft as it:

1. Needs a rebase
2. Hasn't seen any activity in the past couple days

[sagor999]

Thank you @easyCZ
Yes, this PR is paused for now as we are re-thinking our PVC approach a bit.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.