Remove download workspace button from the workspaces list and admin dashboard

[gtsiolis]

Description

Remove download workspace button from admin.

Related Issue(s)

Fixes #14381 #14382

How to test

1. Go to /admin/workspaces.
2. Search for a workspace.
3. Notice the Download Workspace button is now missing.

Release Notes

NONE

Documentation

Werft options:

• /werft with-local-preview
  If enabled this will build install/preview
• /werft with-preview
• /werft with-large-vm
• /werft with-integration-tests=all
  Valid options are all, workspace, webapp, ide

[werft-gitpod-dev-com]

started the job as gitpod-build-gt-remove-download-workspace-button-on-admin.1 because the annotations in the pull request description changed
(with .werft/ from main)

[werft-gitpod-dev-com]

started the job as gitpod-build-gt-remove-download-workspace-button-on-admin.2 because the annotations in the pull request description changed
(with .werft/ from main)

[easyCZ]

If this is just removed from the UI, nothing stops me from going to that URL and still downloading the workspace. Shall we remove the endpoint also?

[gtsiolis]

Thanks for taking a look, @easyCZ! 🍻

I've left some thoughts in #14364 (comment).

[gtsiolis]

This currently links to #7901 as a minimal viable change. If and when we have a section in the docs we can link to for extensive explanation we could do that. Cc @kylos101 @atduarte

From #14364 (comment):

Current state of #14393

[gtsiolis]

Here's how we can proceed with this PR, see #14364 (comment):

So, where can we go from here?

1. Either someone from the WebApp or Workspace team picking up Remove download workspace button from the workspaces list and admin dashboard #14393 to properly resolve Update dashboard to remove download feature #14381 and Update admin page by removing download feature #14382.
2. Keep the Remove download workspace button from the workspaces list and admin dashboard #14393 as a small MVC and merge the change that only removes the UI from the admin dashboard.
3. Closing Remove download workspace button from the workspaces list and admin dashboard #14393 and letting someone from the team create a new PR from scratch.

[laushinka]

1. Either someone from the WebApp or Workspace team picking up Remove download workspace button from admin #14393 to properly resolve Update dashboard to remove download feature #14381 and Update admin page by removing download feature #14382.
2. Keep the Remove download workspace button from admin #14393 as a small MVC and merge the change that only removes the UI from the admin dashboard.
3. Closing Remove download workspace button from admin #14393 and letting someone from the team create a new PR from scratch.

Looks like removing the functionality should be covered in this issue[1], and this PR covers #14382. Maybe we can rename feature to button in the title, and then we can ship this.

[gtsiolis]

Thanks for taking a look @laushinka!

1️⃣ Re-posting from #14364 (comment):

@kylos101 #14393 could already cover #14483, but I'll leave this to @easyCZ to decide, see 3efa8bc from #14393.

2️⃣ This PR will resolve #14381 and #14382.

3️⃣ Also, from #14364 (comment):

I've tried 🅰️ updating also the workspace entry context menu following the designs #14364 (comment) and 🅱️ removing the entrypoint. There's high chance I've removed more than needed or I missed removing more parts for the endpoint. 🛹

---

It would be great if you or someone from the WebApp team could pick this PR to push it through the finish line, as I'm not much familiar with the go lang changes. Feel free to pick this up or close it in favor of a new PR, whatever feels better for you or the team.

[easyCZ]

I can take a look. Will push against this PR directly. Sorry for the delay, didn't see the tags.

[gtsiolis]

Thanks, @easyCZ! 🙏

[easyCZ]

I've removed the backend changes and pushed them into #14518. I've rebased this and we will land the UI side first, then follow-up on the backend.

[easyCZ]

/werft run

👍 started the job as gitpod-build-gt-remove-download-workspace-button-on-admin.7
(with .werft/ from main)

[mads-hartmann]

Added hold as this was blocking the merge queue

[easyCZ]

Rebased again, to grab a fix for CI from #14519

[easyCZ]

/unhold

[gtsiolis]

Thanks @laushinka @easyCZ @mads-hartmann! 🏀

[atduarte]

Hey @gtsiolis! 👋 Removed the release notes as this is not relevant for the Gitpod end user (developer persona).

[gtsiolis]

Sounds good, @atduarte! Thanks! 🏀