-
Notifications
You must be signed in to change notification settings - Fork 660
feat: migrate to ESM and vitest #4461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadavsinai-philips
approved these changes
Mar 10, 2025
@rjaegers what would you say. The change should not be breaking, but it is a big one. I am consider to mark it as a breaking to make the end user aware of this change. Although tested the risk is bigger than most osther changes. What is your view? |
rjaegers
reviewed
Mar 17, 2025
rjaegers
reviewed
Mar 17, 2025
rjaegers
previously approved these changes
Mar 17, 2025
@rjaegers updated, removed useless comments. |
rjaegers
approved these changes
Mar 17, 2025
npalm
pushed a commit
that referenced
this pull request
Mar 18, 2025
🤖 I have created a release *beep* *boop* --- ## [6.4.0](v6.3.2...v6.4.0) (2025-03-18) ### Features * migrate to ESM and vitest ([#4461](#4461)) ([aa62967](aa62967)) ### Bug Fixes * **lambda:** bump cron-parser from 4.9.0 to 5.0.4 in /lambdas ([#4455](#4455)) ([4b446bf](4b446bf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: runners-releaser[bot] <194412594+runners-releaser[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the TypeScript testing framework from Jest to Vitest and transitions the codebase from CommonJS (CJS) to ECMAScript Modules (ESM).
Motivation:
Changes:
package.json
,tsconfig.json
).Testing:
Related Issues:
Potential Risks:
Additional Notes: