Skip to content

Commit 4b446bf

Browse files
fix(lambda): bump cron-parser from 4.9.0 to 5.0.4 in /lambdas (#4455)
Bumps [cron-parser](https://github.com/harrisiirak/cron-parser) from 4.9.0 to 5.0.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/harrisiirak/cron-parser/releases">cron-parser's releases</a>.</em></p> <blockquote> <h2>v5.0.4</h2> <ul> <li>84e100f75d8ae2ab651f8b72c19b00cb871500f0 - Set milliseconds to 0 before returning schedule (<a href="https://redirect.github.com/harrisiirak/cron-parser/issues/368">#368</a>)</li> </ul> <h2>v5.0.3</h2> <ul> <li>e0bda7ec2c66305d87dd75bf902116f60166b2a4 - Parse field for day of week should allow 0 or SUN values (<a href="https://redirect.github.com/harrisiirak/cron-parser/issues/366">#366</a>)</li> </ul> <h2>v5.0.2</h2> <ul> <li>fe6b90eefefec24673ddbfb9c78d8dbc5ac46a63 - Add fs/promises to browser import ignore list (<a href="https://redirect.github.com/harrisiirak/cron-parser/issues/365">#365</a>)</li> </ul> <h2>v5.0.1</h2> <p>This first patch release contains couple of quick bugfixes that were reported after the first release of v5. Thanks for everybody that tried the new version out and provided some feedback.</p> <ul> <li>9b1e0f3e4f8d97fc4a8fd761eec471a4f1df78e0 - Removed unused <code>jest-runner-tsd</code> dev dependency (<a href="https://redirect.github.com/harrisiirak/cron-parser/issues/361">harrisiirak/cron-parser#361</a>)</li> <li>683f58558061a1820427bb2b38f2961ae83dd1dd - Use dynamic loading for <code>fs</code> and <code>fs/promises</code> to restore ability to use this package in the browser environment (<a href="https://redirect.github.com/harrisiirak/cron-parser/issues/362">harrisiirak/cron-parser#362</a>)</li> <li>5e10db0e2a7ee5d6c23bd00c88e096bed1eec2f0 - Remove <code>assert</code> module usage (can't be used in the browser environment without polyfill or included extra package) and improve/add test cases (<a href="https://redirect.github.com/harrisiirak/cron-parser/issues/364">harrisiirak/cron-parser#364</a>)</li> <li>7ca5c94fc570efdae734bcfbe1e5ac8621911b22 - Remove unused <code>.npmignore</code></li> <li>9ddf705708fc8f5c8b4adc993f0040c20e91377c - Fix benchmarking tool for module interface</li> </ul> <h2>v5.0.0 - TypeScript rewrite</h2> <p>All changes come from <a href="https://redirect.github.com/harrisiirak/cron-parser/pull/360">harrisiirak/cron-parser#360</a></p> <h2>Changelog</h2> <ul> <li><strong>BREAKING CHANGE</strong>: Bumped the minimum Node.js version to <strong>&gt;= 18</strong> and TypeScript to <strong>&gt;= 5</strong>.</li> <li><strong>BREAKING CHANGE</strong>: <code>interval.fields</code> (<code>CronExpression.interval</code>) now returns a <strong>readonly</strong> instance of <code>CronFieldsCollection</code> instead of a regular array. See <code>CronFieldsCollection.from</code> for how to modify the underlying data structure.</li> <li><strong>BREAKING CHANGE</strong>: Moved crontab file parsing from <code>CronParser</code> to a standalone <code>CronFileParser</code> class (fixes <a href="https://redirect.github.com/harrisiirak/cron-parser/issues/112">#112</a>).</li> <li>Refactored the codebase to TypeScript (fixes <a href="https://redirect.github.com/harrisiirak/cron-parser/issues/190">#190</a>).</li> <li>Cleaned up test suites, removed duplicate test cases, and switched from <code>tap</code> to <code>jest</code>.</li> <li>Improved documentation and introduced documentation generated by <code>typedoc</code> (fixes <a href="https://redirect.github.com/harrisiirak/cron-parser/issues/309">#309</a>, <a href="https://redirect.github.com/harrisiirak/cron-parser/issues/322">#322</a>, <a href="https://redirect.github.com/harrisiirak/cron-parser/issues/269">#269</a>).</li> <li>Added benchmark tooling to help detect future performance regressions.</li> <li>Added <code>CronExpression.includesDate</code> to evaluate whether a given date matches the pattern (closes <a href="https://redirect.github.com/harrisiirak/cron-parser/issues/299">#299</a>).</li> <li>Fixed issues where certain range and repeat field expressions produced invalid intervals (fixes <a href="https://redirect.github.com/harrisiirak/cron-parser/issues/156">#156</a>).</li> <li>Fixed an issue with day-of-month handling when the range is explicitly set and no wildcard is used (fixes <a href="https://redirect.github.com/harrisiirak/cron-parser/issues/284">#284</a>).</li> <li>Improved repeat serialization for stringification (fixes <a href="https://redirect.github.com/harrisiirak/cron-parser/issues/236">#236</a>).</li> </ul> <h2>Performance improvements</h2> <p>While this release won't address the performance issues reported in <a href="https://redirect.github.com/harrisiirak/cron-parser/issues/287">#287</a>, it will bring some performance improvements of around 20-30% on average, depending on the pattern complexity. The following benchmark results were produced on my 2023 MBP.</p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/harrisiirak/cron-parser/commit/839d9e2d0fea2b0fb98f73baaf2bfb66c1cd524c"><code>839d9e2</code></a> Bump version</li> <li><a href="https://github.com/harrisiirak/cron-parser/commit/84e100f75d8ae2ab651f8b72c19b00cb871500f0"><code>84e100f</code></a> Set milliseconds to 0 before returning schedule (fixes <a href="https://redirect.github.com/harrisiirak/cron-parser/issues/363">#363</a>) (<a href="https://redirect.github.com/harrisiirak/cron-parser/issues/368">#368</a>)</li> <li><a href="https://github.com/harrisiirak/cron-parser/commit/c4a3213f796dee1c5931f7fc4ab1c86ade686459"><code>c4a3213</code></a> Bump version</li> <li><a href="https://github.com/harrisiirak/cron-parser/commit/e0bda7ec2c66305d87dd75bf902116f60166b2a4"><code>e0bda7e</code></a> Parse field for day of week should allow 0 or SUN values (<a href="https://redirect.github.com/harrisiirak/cron-parser/issues/366">#366</a>)</li> <li><a href="https://github.com/harrisiirak/cron-parser/commit/88ee899e8488756f17b081b3aad31e5239ebb762"><code>88ee899</code></a> Bump version</li> <li><a href="https://github.com/harrisiirak/cron-parser/commit/fe6b90eefefec24673ddbfb9c78d8dbc5ac46a63"><code>fe6b90e</code></a> add fs/promises to browser import ignore list (<a href="https://redirect.github.com/harrisiirak/cron-parser/issues/365">#365</a>)</li> <li><a href="https://github.com/harrisiirak/cron-parser/commit/ca3abe2ba0b630a06e374f873f912f0fbaf142ab"><code>ca3abe2</code></a> Bump version</li> <li><a href="https://github.com/harrisiirak/cron-parser/commit/557dbf99ffc18f0f92cee48d02aa9a74e9e07ad1"><code>557dbf9</code></a> Bump version</li> <li><a href="https://github.com/harrisiirak/cron-parser/commit/5e10db0e2a7ee5d6c23bd00c88e096bed1eec2f0"><code>5e10db0</code></a> Remove assert usage for better compability. Add and update test cases to code...</li> <li><a href="https://github.com/harrisiirak/cron-parser/commit/9ddf705708fc8f5c8b4adc993f0040c20e91377c"><code>9ddf705</code></a> Add benchmarking support for new CronExpressionParser interface</li> <li>Additional commits viewable in <a href="https://github.com/harrisiirak/cron-parser/compare/4.9.0...v5.0.4">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=cron-parser&package-manager=npm_and_yarn&previous-version=4.9.0&new-version=5.0.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Niek Palm <[email protected]>
1 parent aa62967 commit 4b446bf

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

lambdas/functions/ami-housekeeper/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"@aws-github-runner/aws-ssm-util": "*",
2929
"@aws-sdk/client-ec2": "^3.767.0",
3030
"@aws-sdk/client-ssm": "^3.759.0",
31-
"cron-parser": "^4.9.0"
31+
"cron-parser": "^5.0.4"
3232
},
3333
"nx": {
3434
"includedScripts": [

lambdas/functions/control-plane/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"@octokit/core": "6.1.4",
4141
"@octokit/plugin-throttling": "9.4.0",
4242
"@octokit/rest": "21.1.1",
43-
"cron-parser": "^4.9.0"
43+
"cron-parser": "^5.0.4"
4444
},
4545
"nx": {
4646
"includedScripts": [

lambdas/functions/control-plane/src/scale-runners/scale-down-config.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const logger = createChildLogger('scale-down-config.ts');
1515

1616
function inPeriod(period: ScalingDownConfig): boolean {
1717
const now = moment(new Date());
18-
const expr = parser.parseExpression(period.cron, {
18+
const expr = parser.parse(period.cron, {
1919
tz: period.timeZone,
2020
});
2121
const next = moment(expr.next().toDate());

lambdas/yarn.lock

+11-11
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ __metadata:
120120
"@vercel/ncc": "npm:^0.38.3"
121121
aws-sdk-client-mock: "npm:^4.1.0"
122122
aws-sdk-client-mock-jest: "npm:^4.1.0"
123-
cron-parser: "npm:^4.9.0"
123+
cron-parser: "npm:^5.0.4"
124124
languageName: unknown
125125
linkType: soft
126126

@@ -173,7 +173,7 @@ __metadata:
173173
"@vercel/ncc": "npm:^0.38.3"
174174
aws-sdk-client-mock: "npm:^4.1.0"
175175
aws-sdk-client-mock-jest: "npm:^4.1.0"
176-
cron-parser: "npm:^4.9.0"
176+
cron-parser: "npm:^5.0.4"
177177
moment-timezone: "npm:^0.5.47"
178178
nock: "npm:^14.0.1"
179179
ts-node: "npm:^10.9.2"
@@ -6573,12 +6573,12 @@ __metadata:
65736573
languageName: node
65746574
linkType: hard
65756575

6576-
"cron-parser@npm:^4.9.0":
6577-
version: 4.9.0
6578-
resolution: "cron-parser@npm:4.9.0"
6576+
"cron-parser@npm:^5.0.4":
6577+
version: 5.0.4
6578+
resolution: "cron-parser@npm:5.0.4"
65796579
dependencies:
6580-
luxon: "npm:^3.2.1"
6581-
checksum: 10c0/348622bdcd1a15695b61fc33af8a60133e5913a85cf99f6344367579e7002896514ba3b0a9d6bb569b02667d6b06836722bf2295fcd101b3de378f71d37bed0b
6580+
luxon: "npm:^3.5.0"
6581+
checksum: 10c0/cac705efad1976d3441e967083dc786fb1dca5dbcdafc73e26774a231fed7d6efaf62d2b155c4b28232e4a3501d65e71d250b2d319c951ec35d3f3dc6ac87c98
65826582
languageName: node
65836583
linkType: hard
65846584

@@ -8600,10 +8600,10 @@ __metadata:
86008600
languageName: node
86018601
linkType: hard
86028602

8603-
"luxon@npm:^3.2.1":
8604-
version: 3.3.0
8605-
resolution: "luxon@npm:3.3.0"
8606-
checksum: 10c0/47f8e1e96b25441c799b8aa833b3f007fb1854713bcffc8c3384eda8e61fc9af1f038474d137274d2d386492f341c8a8c992fc78c213adfb3143780feba2776c
8603+
"luxon@npm:^3.5.0":
8604+
version: 3.5.0
8605+
resolution: "luxon@npm:3.5.0"
8606+
checksum: 10c0/335789bba95077db831ef99894edadeb23023b3eb2137a1b56acd0d290082b691cf793143d69e30bc069ec95f0b49f36419f48e951c68014f19ffe12045e3494
86078607
languageName: node
86088608
linkType: hard
86098609

0 commit comments

Comments
 (0)