Skip to content

Set singleRun to true and remove from all karma start scripts #8484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2024
Merged

Set singleRun to true and remove from all karma start scripts #8484

merged 1 commit into from
Sep 10, 2024

Conversation

dlarocque
Copy link
Contributor

Enable singleRun once in the base Karma config instead of setting the flag in each of the karma scripts.

The test:debug scripts don't set --single-run, but I don't believe that enabling it should have any effect. If it needs to be disabled for these, we can set --no-single-run just for the debug scripts.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2024

⚠️ No Changeset found

Latest commit: 29aa089

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (3670ab8) and merge commit (0926e21).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/z59FU30ByM.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (3670ab8) and merge commit (0926e21).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GHKaYL6XNq.html

@dlarocque dlarocque merged commit ca4dbcf into main Sep 10, 2024
41 of 43 checks passed
@dlarocque dlarocque deleted the dl/set-single-run-default branch September 10, 2024 14:05
dlarocque added a commit that referenced this pull request Sep 16, 2024
@dlarocque
Set singleRun to true and remove from all karma start scripts (#8484)
24fa8ca
@firebase firebase locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@erikeldridge erikeldridge Awaiting requested review from erikeldridge erikeldridge is a code owner

@jposuna jposuna Awaiting requested review from jposuna

@avolkovi avolkovi Awaiting requested review from avolkovi avolkovi is a code owner

@yoyomyo yoyomyo Awaiting requested review from yoyomyo yoyomyo is a code owner

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh Xiaoshouzi-gh is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@zwu52 zwu52 Awaiting requested review from zwu52 zwu52 is a code owner

@maneesht maneesht Awaiting requested review from maneesht maneesht is a code owner

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang tonyjhuang is a code owner

@aashishpatil-g aashishpatil-g Awaiting requested review from aashishpatil-g aashishpatil-g is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlarocque @google-oss-bot @hsubox76