Skip to content

Commit 3670ab8

Browse files
authored
Use default concurrency value for lerna run (#8462)
The default concurrency value for leran run is the number of logical CPU cores. This is better than arbitrarily using 4 threads, since different machines may be able to handle more.
1 parent 15c36cc commit 3670ab8

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

.github/workflows/test-all.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ jobs:
9292
- name: Run unit tests
9393
# Ignore auth and firestore since they're handled in their own separate jobs.
9494
run: |
95-
xvfb-run yarn lerna run --ignore '{firebase-messaging-integration-test,@firebase/auth*,@firebase/firestore*,firebase-firestore-integration-test}' --concurrency 4 test:ci
95+
xvfb-run yarn lerna run --ignore '{firebase-messaging-integration-test,@firebase/auth*,@firebase/firestore*,firebase-firestore-integration-test}' test:ci
9696
node scripts/print_test_logs.js
9797
env:
9898
FIREBASE_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}
@@ -142,7 +142,7 @@ jobs:
142142
run: echo "FIREBASE_CI_TEST_START_TIME=$(date +%s)" >> $GITHUB_ENV
143143
- name: Run unit tests
144144
run: |
145-
xvfb-run yarn lerna run --concurrency 4 test:ci --scope '@firebase/auth*'
145+
xvfb-run yarn lerna run test:ci --scope '@firebase/auth*'
146146
node scripts/print_test_logs.js
147147
env:
148148
FIREBASE_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}
@@ -182,7 +182,7 @@ jobs:
182182
run: echo "FIREBASE_CI_TEST_START_TIME=$(date +%s)" >> $GITHUB_ENV
183183
- name: Run unit tests
184184
run: |
185-
xvfb-run yarn lerna run --concurrency 4 test:ci --scope '@firebase/firestore*'
185+
xvfb-run yarn lerna run test:ci --scope '@firebase/firestore*'
186186
node scripts/print_test_logs.js
187187
env:
188188
FIREBASE_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030
"repl": "node tools/repl.js",
3131
"release": "ts-node-script scripts/release/cli.ts",
3232
"pretest": "node tools/pretest.js",
33-
"test": "lerna run --ignore firebase-messaging-integration-test --concurrency 4 --stream test",
34-
"test:ci": "lerna run --ignore firebase-messaging-integration-test --concurrency 4 test:ci",
33+
"test": "lerna run --ignore firebase-messaging-integration-test --stream test",
34+
"test:ci": "lerna run --ignore firebase-messaging-integration-test test:ci",
3535
"pretest:coverage": "mkdirp coverage",
3636
"ci:coverage": "lcov-result-merger 'packages/**/lcov.info' 'lcov-all.info'",
3737
"test:coverage": "lcov-result-merger 'packages/**/lcov.info' | coveralls",

scripts/ci-test/test_changed.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ async function runTests(config: TestConfig) {
5959
process.exit(0);
6060
}
6161

62-
const lernaCmd = ['lerna', 'run', '--concurrency', '4'];
62+
const lernaCmd = ['lerna', 'run'];
6363
console.log(chalk`{blue Running tests in:}`);
6464
for (const task of testTasks) {
6565
if (task.reason === TestReason.Changed) {

0 commit comments

Comments
 (0)