Update rtdb types #840
Merged
Update rtdb types #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for sending this over. Due to how our repo is structured, these changes need to be replicated in one more place (https://github.com/firebase/firebase-js-sdk/blob/dd11cd17aada45a19732d6517a7d740e722546d2/packages/firebase/index.d.ts). I will do this myself once CI passes and this PR is merged. |
schmidt-sebastian
added a commit
that referenced
this pull request
May 18, 2018
This is a follow-up PR to #840
schmidt-sebastian
approved these changes
May 18, 2018
|
Thanks! |
|
FYI while being more explicit is useful, mind that changes such as this are breaking changes for typescript users. https://travis-ci.org/angular/angularfire2/jobs/386001074 |
|
@schmidt-sebastian please watch out for what should be major changes to the types in future PRs. Angularfire is still in RC still so I'm not stressing out too much but this could break the build for anyone else using TS. IMO correct thing to do would be: // TODO(semver): drop "string" in 6.0 release
type EventType = string | 'value' | 'child_added' | 'child_changed' | 'child_moved' | 'child_removed'; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated some of the type definitions.
Fixes #306, #555.