Skip to content

Updates to Database Type Definitions #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hiranya911 opened this issue Nov 8, 2017 · 3 comments · Fixed by #840
Closed

Updates to Database Type Definitions #306

hiranya911 opened this issue Nov 8, 2017 · 3 comments · Fixed by #840

Comments

@hiranya911
Copy link
Contributor

  • Expose ThenableReference type from the database type definitions.
  • Currently then() and catch() methods are exposed from the Reference type, which doesn't seem to be correct. Those belong in ThenableReference.
  • Add EventType type:
type EventType = 'value' | 'child_added' | 'child_changed' | 'child_moved' | 'child_removed';
@google-oss-bot
Copy link
Contributor

Hey there! I couldn't figure out what this issue is about, so I've labeled it for a human to triage. Hang tight.

@google-oss-bot
Copy link
Contributor

Hmmm this issue does not seem to follow the issue template. Make sure you provide all the required information.

@jspri
Copy link
Contributor

jspri commented Jan 3, 2018

then and catch still exist on all references https://github.com/firebase/firebase-js-sdk/blob/master/packages/database/src/api/Reference.ts#L45

but the exposed types were fixed in #334.

type EventType = 'value' | 'child_added' | 'child_changed' | 'child_moved' | 'child_removed';

Is the only point that still needs to be addressed.

@firebase firebase locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants