Skip to content

Testing composite index queries against production #7632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 53 commits into from
Oct 4, 2023
Merged

Testing composite index queries against production #7632

merged 53 commits into from
Oct 4, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Sep 14, 2023 •
edited
Loading

  • create a CompositeIndexTestHelper class to run tests with composite index against production
  • add terraform to create composite indexes inside packages/firestore
  • move part of the OR queries to composite index query test file.

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: e78dff5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 14, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (eff9530) and merge commit (18c1dd6).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NEx5HI59Zn.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 14, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (eff9530) and merge commit (18c1dd6).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NdFyPif7bO.html

@milaGGL milaGGL self-assigned this Sep 15, 2023
@milaGGL
try github workflow
85933f6
@milaGGL
move .tf file up
b073d8f
@milaGGL
copy project.json
b8f4bee
@milaGGL
Update composite_index.tf
4d75c75
@milaGGL
Update composite_index.tf
e0d3a11
@milaGGL
Update composite_index.tf
b869a52
@milaGGL
add env:
6f3b983
@milaGGL
Update test-changed-firestore-integration.yml
f26a87e
@milaGGL
Update test-changed-firestore-integration.yml
c62c8aa
@milaGGL
Update composite_index.tf
9e44a4c
@milaGGL
Update composite_index.tf
3b192f0
@milaGGL
try FIREBASE_CLI_TOKEN
987800f
@milaGGL
Revert "try FIREBASE_CLI_TOKEN"
27ad483 
This reverts commit 987800f.
@milaGGL
Update test-changed-firestore-integration.yml
f42e295
@milaGGL
Revert "Update test-changed-firestore-integration.yml"
a913d74 
This reverts commit f42e295.
@milaGGL
remove services
75a33da
@milaGGL
Update test-changed-firestore-integration.yml
5e4464c
@milaGGL
Update test-changed-firestore.yml
b6bdc65
@milaGGL
Update test-changed-firestore.yml
7035d6c
@milaGGL
check project
80c95eb
@milaGGL
remove unnecessary terraform run
c32b3d9
@milaGGL
run all integration tests
aed8c2f
@milaGGL
skip MIEQ
4531fdb
ehsannas
ehsannas reviewed Sep 21, 2023
View reviewed changes
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally great! Just a couple of minor nits pointed out below.

@milaGGL milaGGL requested a review from ehsannas September 25, 2023 14:10
@milaGGL milaGGL requested a review from DellaBitta September 28, 2023 14:33
This was referenced Sep 28, 2023
Merged
Merged
ehsannas
ehsannas reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final request below.

@milaGGL milaGGL requested a review from ehsannas October 3, 2023 15:55
ehsannas
ehsannas approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@milaGGL milaGGL merged commit cbfd14c into master Oct 4, 2023
@milaGGL milaGGL deleted the mila/composite-index-testing branch October 4, 2023 14:26
milaGGL added a commit to firebase/firebase-android-sdk that referenced this pull request Oct 5, 2023
@milaGGL
Testing composite index queries against production (#5352)
26eb260 
port from: firebase/firebase-js-sdk#7632
@firebase firebase locked and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

@DellaBitta DellaBitta DellaBitta approved these changes

Assignees

@milaGGL milaGGL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@milaGGL @google-oss-bot @ehsannas @DellaBitta