Skip to content

Testing composite index queries against production #5352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Oct 5, 2023
Merged

Testing composite index queries against production #5352

merged 18 commits into from
Oct 5, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Sep 21, 2023 •
edited
Loading

@milaGGL milaGGL self-assigned this Sep 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@milaGGL milaGGL changed the title add composite index test helper Testing composite index queries against production Sep 21, 2023
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 21, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.17% (dc48e69) to 50.18% (558d1f5) by +0.01%.

    FilenameBase (dc48e69)Merge (558d1f5)Diff
    DefaultPersistenceManager.java74.76%75.73%+0.97%

  • firebase-firestore

    Overall coverage changed from 44.75% (dc48e69) to 44.76% (558d1f5) by +0.00%.

    FilenameBase (dc48e69)Merge (558d1f5)Diff
    SetMutation.java94.44%97.22%+2.78%

  • firebase-perf

    Overall coverage changed from 70.95% (dc48e69) to 70.97% (558d1f5) by +0.02%.

    FilenameBase (dc48e69)Merge (558d1f5)Diff
    RateLimiter.java90.77%91.54%+0.77%

  • firebase-storage

    Overall coverage changed from 84.29% (dc48e69) to 84.33% (558d1f5) by +0.04%.

    FilenameBase (dc48e69)Merge (558d1f5)Diff
    StreamDownloadTask.java88.41%88.89%+0.48%

  • firebase-messaging

    FilenameBase (dc48e69)Merge (558d1f5)Diff
    FirebaseMessaging.java72.69%73.57%+0.88%
    RequestDeduplicator.java90.00%80.00%-10.00%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Q4H6dxdChD.html

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023 •
edited
Loading

Unit Test Results

     936 files  ±0       936 suites  ±0   38m 47s ⏱️ -26s
  5 096 tests ±0    5 075 ✔️ +1  21 💤 ±0  0 ❌  - 1 
10 277 runs  ±0  10 235 ✔️ +1  42 💤 ±0  0 ❌  - 1 

Results for commit 61c69b3. ± Comparison against base commit dc48e69.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 21, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (dc48e69) and merge commit (558d1f5).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/N8p7u1Jn73.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 21, 2023 •
edited
Loading

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (558d1f5) and the base commit (dc48e69) are not available.

No macrobenchmark data found for the base commit (dc48e69). Analysis for the CI merge commit (558d1f5) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gaCwsMZZ3t/index.html

@milaGGL milaGGL marked this pull request as ready for review September 27, 2023 17:22
@milaGGL milaGGL requested a review from ehsannas September 28, 2023 15:08
ehsannas
ehsannas reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add the few additional functions (updateDoc, getDoc, and getDocs) similar to the Web.

ehsannas
ehsannas reviewed Oct 3, 2023
View reviewed changes
@milaGGL milaGGL requested a review from ehsannas October 4, 2023 15:46
@milaGGL milaGGL merged commit 26eb260 into master Oct 5, 2023
@milaGGL milaGGL deleted the mila/composite-index-testing branch October 5, 2023 15:33
@firebase firebase locked and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@ehsannas ehsannas ehsannas approved these changes

Assignees

@milaGGL milaGGL

Labels
no-changelog size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@milaGGL @google-oss-bot @rlazo @ehsannas