-
Notifications
You must be signed in to change notification settings - Fork 938
Fix and skip flaky Firestore tests #7552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Report 1Affected ProductsNo changes between base commit (040b0b4) and merge commit (a0e37a5).Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be very helpful if the comments around the commented code and skipped tests were written as a "TODO" referencing the Buganizer ticket, something like this:
TODO(b/295872012) Uncomment the expectation check below once the root cause of the flakiness it causes is fixed
and
TODO(b/295872012) Stop skipping this test once the flaky timeouts it experiences are fixed
Size Analysis Report 1Affected ProductsNo changes between base commit (040b0b4) and merge commit (a0e37a5).Test Logs |
internal issue: b/295872012