Skip to content

Fix and skip flaky Firestore tests #7552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Fix and skip flaky Firestore tests #7552

merged 3 commits into from
Aug 14, 2023

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Aug 14, 2023

internal issue: b/295872012

@wu-hui wu-hui requested review from a team as code owners August 14, 2023 15:03
@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023

⚠️ No Changeset found

Latest commit: f1b7044

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 14, 2023

Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be very helpful if the comments around the commented code and skipped tests were written as a "TODO" referencing the Buganizer ticket, something like this:

TODO(b/295872012) Uncomment the expectation check below once the root cause of the flakiness it causes is fixed

and

TODO(b/295872012) Stop skipping this test once the flaky timeouts it experiences are fixed

@dconeybe dconeybe assigned dconeybe and wu-hui and unassigned dconeybe Aug 14, 2023
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 14, 2023

@wu-hui wu-hui assigned dconeybe and unassigned wu-hui Aug 14, 2023
@dconeybe dconeybe assigned wu-hui and unassigned dconeybe Aug 14, 2023
@wu-hui wu-hui assigned dconeybe and unassigned wu-hui Aug 14, 2023
@dconeybe dconeybe assigned wu-hui and unassigned dconeybe Aug 14, 2023
@wu-hui wu-hui merged commit f497a40 into master Aug 14, 2023
@wu-hui wu-hui deleted the wuandy/ReduceFlakiness branch August 14, 2023 17:06
@firebase firebase locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants