Skip to content

Commit f1b7044

Browse files
committed
more nits
1 parent 692850f commit f1b7044

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

packages/firestore/test/integration/api/database.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -800,6 +800,7 @@ apiDescribe('Database', persistence => {
800800
expect(snap.data()).to.deep.equal({ a: 1 });
801801
// This event could be a metadata change for fromCache as well.
802802
// We comment this line out to reduce flakiness.
803+
// TODO(b/295872012): Figure out a way to check for all scenarios.
803804
// expect(snap.metadata.hasPendingWrites).to.be.false;
804805
});
805806
});
@@ -830,6 +831,7 @@ apiDescribe('Database', persistence => {
830831
expect(snap.data()).to.deep.equal(changedData);
831832
// This event could be a metadata change for fromCache as well.
832833
// We comment this line out to reduce flakiness.
834+
// TODO(b/295872012): Figure out a way to check for all scenarios.
833835
// expect(snap.metadata.hasPendingWrites).to.be.false;
834836
});
835837
});

packages/firestore/test/integration/api/query.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,8 @@ apiDescribe('Queries', persistence => {
444444
});
445445
});
446446

447-
// TODO(b/295872012): This test is skipped due to the flakiness around the checks of hasPendingWrites.
447+
// TODO(b/295872012): This test is skipped due to the flakiness around the
448+
// checks of hasPendingWrites.
448449
// We should investigate if this is an acutal bug.
449450
// eslint-disable-next-line no-restricted-properties
450451
it.skip('can listen for the same query with different options', () => {

0 commit comments

Comments
 (0)