Skip to content

Commit 692850f

Browse files
committed
add todos
1 parent 12f63d1 commit 692850f

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

packages/firestore/test/integration/api/numeric_transforms.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,8 @@ apiDescribe('Numeric Transforms:', persistence => {
102102
});
103103
});
104104

105-
// Skipped due to test flakiness: timeout
105+
// TODO(b/295872012): This test is skipped due to a timeout test flakiness
106+
// We should investigate if this is an acutal bug.
106107
// eslint-disable-next-line no-restricted-properties
107108
it.skip('increment existing integer with integer', async () => {
108109
await withTestSetup(async () => {
@@ -160,8 +161,9 @@ apiDescribe('Numeric Transforms:', persistence => {
160161
});
161162
});
162163

163-
// Skipped due to test flakiness:
164+
// TODO(b/295872012): This test is skipped due to test flakiness:
164165
// AssertionError: expected 0.122 to be close to 0.111 +/- 0.000001
166+
// We should investigate the root cause, it might be an acutal bug.
165167
// eslint-disable-next-line no-restricted-properties
166168
it.skip('multiple double increments', async () => {
167169
await withTestSetup(async () => {

packages/firestore/test/integration/api/query.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,8 @@ apiDescribe('Queries', persistence => {
444444
});
445445
});
446446

447-
// Skips because the checks on hasPendingWrites are flaky.
447+
// TODO(b/295872012): This test is skipped due to the flakiness around the checks of hasPendingWrites.
448+
// We should investigate if this is an acutal bug.
448449
// eslint-disable-next-line no-restricted-properties
449450
it.skip('can listen for the same query with different options', () => {
450451
const testDocs = { a: { v: 'a' }, b: { v: 'b' } };

0 commit comments

Comments
 (0)