Firestore: testing_hooks.ts: move some logic into testing_hooks_spi.ts #7543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…lterMismatchCallback doesn't get mangled by rollup in renameInternals()
Size Report 1Affected Products
Test Logs |
dconeybe
commented
Aug 10, 2023
Size Analysis Report 1This report is too large (68,597 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
…ess.exit(1)` to fix truncated output
…runcatedLogOutputFix' into TestingHooksSpi
dconeybe
changed the base branch from
master
to
dconeybe/RunTestsInCiJsTruncatedLogOutputFix
ehsannas
approved these changes
Aug 15, 2023
dconeybe
requested review from
a team,
lisajian,
prameshj,
renkelvin and
sam-gc
as code owners
dconeybe
changed the base branch from
dconeybe/RunTestsInCiJsTruncatedLogOutputFix
to
master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7149 a "testing hooks" class was added, which enables Firestore's integration tests to reach into the SDK's internals to validate behavior that is not visible from the public API surface. This original testing hooks implementation had two subtle problems:
This PR fixes all of these issues by putting the actual testing hooks logic behind an interface. Instead of depending on the actual testing hook logic, the SDK's internals instead depend on the "SPI" (the "service provider interface"), which is basically one global variable and a bunch of TypeScript interface declarations (which do not contribute to bundle size). The integration tests, however, have a strong dependency on the testing hooks logic and bear the bundle size cost of including that code, which is fine since they're just integration tests.
This PR was motivated by #7542, which suffered from both of the problems identified above.