-
Notifications
You must be signed in to change notification settings - Fork 926
[Auth] Fix auth event uncancellable bug #7498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 8bac951 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Looks great, thank you! You would also need to create a changeset with |
packages/auth/package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@firebase/auth", | |||
"version": "1.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be reverted. i don't think we change this manually, right @hsubox76 ?
9a81f12
to
2e45a15
Compare
I'm sorry if I misunderstood. I tried |
.changeset/mean-candles-approve.md
Outdated
'@firebase/auth': patch | ||
--- | ||
|
||
Fix auth event uncancellable bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: include reference to #7383
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added issue number
Please run |
I applied |
I see a couple of optional CI jobs passing, but i think they are unrelated to this PR. @DellaBitta can you confirm? I can merge the PR after you give the +1. Thanks! |
Some of the CI failures are due to a CLI configuration issue that's fixed in |
I'm sorry, I didn't realize it was waiting for my action. Thank you for the merge. |
This will fix the issue reported in #7383.
I have implemented a change that only requires a small adjustment in the code.
This patch has resolved the issue in the reproduction project that I reported (https://github.com/omochi/firebase-auth-js-cancel-bug).