Skip to content

[Auth] Fix auth event uncancellable bug #7498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 14, 2023

Conversation

omochi
Copy link
Contributor

@omochi omochi commented Jul 26, 2023

This will fix the issue reported in #7383.
I have implemented a change that only requires a small adjustment in the code.
This patch has resolved the issue in the reproduction project that I reported (https://github.com/omochi/firebase-auth-js-cancel-bug).

@omochi omochi requested review from lisajian, prameshj, renkelvin, sam-gc and a team as code owners July 26, 2023 06:07
@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

🦋 Changeset detected

Latest commit: 8bac951

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla
Copy link

google-cla bot commented Jul 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@prameshj
Copy link
Contributor

Looks great, thank you!

You would also need to create a changeset with yarn changeset add so we can include it in the next patch release for firebase/auth.

@@ -1,6 +1,6 @@
{
"name": "@firebase/auth",
"version": "1.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be reverted. i don't think we change this manually, right @hsubox76 ?

@omochi omochi force-pushed the fix-auth-event-cancel-bug branch from 9a81f12 to 2e45a15 Compare July 28, 2023 10:11
@omochi omochi requested review from a team as code owners July 28, 2023 10:13
@omochi
Copy link
Contributor Author

omochi commented Jul 28, 2023

I'm sorry if I misunderstood. I tried $ yarn changeset add. Is this correct?

'@firebase/auth': patch
---

Fix auth event uncancellable bug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: include reference to #7383

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added issue number

@prameshj
Copy link
Contributor

Please run yarn format to fix the CI. Thanks!

@omochi
Copy link
Contributor Author

omochi commented Aug 1, 2023

I applied $ yarn format.

@prameshj
Copy link
Contributor

prameshj commented Aug 1, 2023

I see a couple of optional CI jobs passing, but i think they are unrelated to this PR. @DellaBitta can you confirm? I can merge the PR after you give the +1. Thanks!

@DellaBitta
Copy link
Contributor

Some of the CI failures are due to a CLI configuration issue that's fixed in master. Can you merge master into this branch and see if there are other obscured failures?

@prameshj
Copy link
Contributor

prameshj commented Aug 14, 2023

@omochi Can you merge master into this branch and push the commit, as David suggested? Thanks!

Edit - Got confirmation from @hsubox76 that the failing CI is unrelated to the changes. Merging.

@prameshj prameshj merged commit 5dac8b3 into firebase:master Aug 14, 2023
@omochi
Copy link
Contributor Author

omochi commented Aug 14, 2023

I'm sorry, I didn't realize it was waiting for my action. Thank you for the merge.

@google-oss-bot google-oss-bot mentioned this pull request Aug 15, 2023
@firebase firebase locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants