[Auth] Build state listeners on streams

[omochi]

This PR fix #7383 which I reported.

I have confirmed that the problem has been resolved, but the overall automated testing has not yet been conducted. I will submit a pull request to share the approach to the correction promptly.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 193b80a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[prameshj]

Thanks for creating this PR and for the thorough analysis!

I wonder if a smaller scoped change like below would work (i have not tried this, just thinking out aloud). I also posted this on the issue:

private registerStateListener(
subscription: Subscription,
nextOrObserver: NextOrObserver,
error?: ErrorFn,
completed?: CompleteFn
): Unsubscribe {
if (this._deleted) {
return () => {};
}

• let isUnsubscribed = false;
  const cb =
  typeof nextOrObserver === 'function'
  ? nextOrObserver
  : nextOrObserver.next.bind(nextOrObserver);

  const promise = this._isInitialized
  ? Promise.resolve()
  : this._initializationPromise;
  _assert(promise, this, AuthErrorCode.INTERNAL_ERROR);
  // The callback needs to be called asynchronously per the spec.
  // eslint-disable-next-line @typescript-eslint/no-floating-promises

  • promise.then(() => {if (isUnsubscribed) { return; }; cb(this.currentUser)});

  if (typeof nextOrObserver === 'function') {
  + Unsubscribe unsubscribe = subscription.addObserver(nextOrObserver, error, completed);
  + return {isUnsubscribed = true; unsubscribe();}
  } else {
  + Unsubscribe unsubscribe = subscription.addObserver(nextOrObserver);
  + return {isUnsubscribed = true; unsubscribe();}
  }
  }

Since the Observer logic is also used outside of Auth (in storage and firestore), i wonder if we can do a smaller fix. Thanks!

[omochi]

The issue is fixed by #7498