Skip to content

Firestore: transactions.test.ts: increase the timeout of some tests to reduce flakiness #7399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Firestore: transactions.test.ts: increase the timeout of some tests to reduce flakiness #7399

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f62a2a2
transactions.test.ts: increase the timeout of some tests to reduce fl…
dconeybe Jun 28, 2023
9384f10
Merge remote-tracking branch 'origin/master' into TransactionTestTime…
dconeybe Jun 28, 2023
5cc825d
Increase the timeouts in firestore/compat tests as well
dconeybe Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/firestore/test/integration/api/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ apiDescribe('Database transactions', (persistence: boolean) => {
.run(get, set1, set2)
.expectDoc({ foo: 'bar2' });
});
});
}).timeout(10000);

// This test is identical to the test above, except that withNonexistentDoc()
// is replaced by withDeletedDoc(), to guard against regression of
Expand Down Expand Up @@ -355,7 +355,7 @@ apiDescribe('Database transactions', (persistence: boolean) => {
.expectDoc({ foo: 'bar2' });
await tt.withDeletedDoc().run(get, set1, set2).expectDoc({ foo: 'bar2' });
});
});
}).timeout(10000);

it('runs transactions on existing document', async () => {
return withTestDb(persistence, async db => {
Expand Down