Skip to content

Firestore: transactions.test.ts: increase the timeout of some tests to reduce flakiness #7399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2023
Merged

Firestore: transactions.test.ts: increase the timeout of some tests to reduce flakiness #7399

merged 3 commits into from
Jun 29, 2023

Conversation

dconeybe
Copy link
Contributor

These tests were flirting with the 5-second timeout, and sometimes timed out when run locally. This PR increases the timeout to 10 seconds to reduce the flakiness.

@dconeybe dconeybe requested review from a team as code owners June 28, 2023 15:45
@dconeybe dconeybe self-assigned this Jun 28, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5cc825d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dconeybe dconeybe requested a review from milaGGL June 28, 2023 15:46
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 28, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (a6d516d) and merge commit (e152948).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PKFJs8afgi.html

milaGGL
milaGGL approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test passed locally. LGTM.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 28, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (a6d516d) and merge commit (e152948).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7R5XTDK2PD.html

@dconeybe dconeybe merged commit 35c35fe into master Jun 29, 2023
@dconeybe dconeybe deleted the dconeybe/TransactionTestTimeoutIncrease branch June 29, 2023 13:24
@firebase firebase locked and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@milaGGL milaGGL milaGGL approved these changes

Assignees

@dconeybe dconeybe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @google-oss-bot @milaGGL