Skip to content

Firestore: Remove the no-ios tag from bloom filter spec tests #7372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2023
Merged

Firestore: Remove the no-ios tag from bloom filter spec tests #7372

merged 2 commits into from
Jun 21, 2023

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jun 20, 2023 •
edited
Loading

Remove the no-ios tag from bloom filter spec tests, now that the feature has been merged into the ios sdk in firebase/firebase-ios-sdk#11457.

The spec test changes from this PR were ported to the Android SDK in firebase/firebase-android-sdk#5088. Porting to the iOS SDK is not needed since these changes were included in firebase/firebase-ios-sdk#11457.

@dconeybe dconeybe self-assigned this Jun 20, 2023
@dconeybe dconeybe requested review from a team as code owners June 20, 2023 16:18
@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: b4d81b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 20, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (59c7b58) and merge commit (2c79296).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7KVTWwleWc.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 20, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (59c7b58) and merge commit (2c79296).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hcXAYNzsYt.html

@dconeybe dconeybe force-pushed the dconeybe/BloomFilterSpecTestsIosEnable branch from 87b8c22 to b4d81b0 Compare June 20, 2023 18:24
dconeybe added a commit to firebase/firebase-android-sdk that referenced this pull request Jun 20, 2023
@dconeybe
Sync spec tests with changes from firebase/firebase-js-sdk#7372
fc4b907
@dconeybe dconeybe mentioned this pull request Jun 20, 2023
Merged
milaGGL
milaGGL approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dconeybe dconeybe merged commit 2e8039e into master Jun 21, 2023
@dconeybe dconeybe deleted the dconeybe/BloomFilterSpecTestsIosEnable branch June 21, 2023 05:14
dconeybe added a commit to firebase/firebase-android-sdk that referenced this pull request Jun 21, 2023
@dconeybe
Sync spec tests with changes from firebase/firebase-js-sdk#7372 (#5088)
dd710a7
@firebase firebase locked and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@milaGGL milaGGL milaGGL approved these changes

Assignees

@dconeybe dconeybe

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @google-oss-bot @milaGGL